Skip to content

Fix filter in gantt and grid view#55845

Merged
jscheffl merged 1 commit into
apache:mainfrom
guan404ming:fix-grid-filter
Sep 18, 2025
Merged

Fix filter in gantt and grid view#55845
jscheffl merged 1 commit into
apache:mainfrom
guan404ming:fix-grid-filter

Conversation

@guan404ming

@guan404ming guan404ming commented Sep 18, 2025

Copy link
Copy Markdown
Member

Related Issue

closes #55782

Why

The filter added recently is not integrated with gantt view.

How

Right now I’m not implementing the unselect action. I think the filter should only apply to the grid view and gantt view. To implement unselect action could somehow impact the UX, since users probably wouldn’t expect clicking an option to trigger a page change. But I’m happy to discuss this further and open to any idea!

Screen.Recording.2025-09-19.at.12.37.28.AM.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 18, 2025
@jscheffl

Copy link
Copy Markdown
Contributor

FYI @dheerajturaga

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well. Cool!

@jscheffl jscheffl added the type:bug-fix Changelog: Bug Fixes label Sep 18, 2025
@jscheffl jscheffl added this to the Airflow 3.1.0 milestone Sep 18, 2025
@jscheffl jscheffl merged commit a69fd9b into apache:main Sep 18, 2025
58 checks passed
kaxil pushed a commit that referenced this pull request Sep 18, 2025
@guan404ming

Copy link
Copy Markdown
Member Author

Thanks!

@guan404ming guan404ming deleted the fix-grid-filter branch September 19, 2025 00:33
dheerajturaga added a commit to dheerajturaga/airflow that referenced this pull request Sep 20, 2025
…#55845

The issue was that the Gantt chart wasn't using the same filters as the Grid view. When you set a DAG run state filter in the Options
  menu, it would filter the Grid view but not the Gantt chart. Now both views will be synchronized with the same filtering criteria.
jscheffl pushed a commit that referenced this pull request Sep 20, 2025
* feat(ui): add DAG run state filter to grid view options

  Add filtering by DAG run state (queued, running, success, failed) to the grid view options panel, following the same pattern as the
  existing DagRuns.tsx implementation.

* Add testsgit add .

* Gantt chart filtering issue by applying the same pattern as PR #55845

The issue was that the Gantt chart wasn't using the same filters as the Grid view. When you set a DAG run state filter in the Options
  menu, it would filter the Grid view but not the Gantt chart. Now both views will be synchronized with the same filtering criteria.
KatalKavya96 pushed a commit to KatalKavya96/airflow that referenced this pull request Sep 22, 2025
* feat(ui): add DAG run state filter to grid view options

  Add filtering by DAG run state (queued, running, success, failed) to the grid view options panel, following the same pattern as the
  existing DagRuns.tsx implementation.

* Add testsgit add .

* Gantt chart filtering issue by applying the same pattern as PR apache#55845

The issue was that the Gantt chart wasn't using the same filters as the Grid view. When you set a DAG run state filter in the Options
  menu, it would filter the Grid view but not the Gantt chart. Now both views will be synchronized with the same filtering criteria.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gantt view issue with 'Triggering User Name' field

2 participants