Skip to content

uv version bump to 0.4.7#42274

Merged
vincbeck merged 6 commits intoapache:mainfrom
dirrao:uv_version_bump_0.4.10
Sep 25, 2024
Merged

uv version bump to 0.4.7#42274
vincbeck merged 6 commits intoapache:mainfrom
dirrao:uv_version_bump_0.4.10

Conversation

@dirrao
Copy link
Contributor

@dirrao dirrao commented Sep 17, 2024

uv version bump from 0.4.1 to 0.4.7

@dirrao dirrao requested review from ashb and potiuk as code owners September 17, 2024 11:21
@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels Sep 17, 2024
@topherinternational
Copy link
Contributor

Out of interest (I love uv) I took a quick look here and was able to reproduce the failing test locally. First the error:

+ uv pip install --python /usr/local/bin/python --resolution lowest-direct --upgrade --editable '.[google]'
  error: Failed to download and build `pandas==0.1`
    Caused by: Build backend failed to determine extra requires with `build_wheel()` with exit status: 1
  --- stdout:
  
  --- stderr:
  Traceback (most recent call last):
    File "<string>", line 14, in <module>
    File "/tmp/.tmpKLzrjb/builds-v0/.tmpp1FCdI/lib/python3.8/site-packages/setuptools/build_meta.py", line 332, in get_requires_for_build_wheel
      return self._get_build_requires(config_settings, requirements=[])
    File "/tmp/.tmpKLzrjb/builds-v0/.tmpp1FCdI/lib/python3.8/site-packages/setuptools/build_meta.py", line 302, in _get_build_requires
      self.run_setup()
    File "/tmp/.tmpKLzrjb/builds-v0/.tmpp1FCdI/lib/python3.8/site-packages/setuptools/build_meta.py", line 503, in run_setup
      super().run_setup(setup_script=setup_script)
    File "/tmp/.tmpKLzrjb/builds-v0/.tmpp1FCdI/lib/python3.8/site-packages/setuptools/build_meta.py", line 318, in run_setup
      exec(code, locals())
    File "<string>", line 5, in <module>
  ModuleNotFoundError: No module named 'numpy'

Repro steps for me (on an Intel OS X Mac w/ homebrew) were:

  1. Create and activate a fresh Python 3.8 environment
  2. Install uv
  3. Run the uv command args from the trace above (removing the system python marg)
cd <airflow repo directory>
python3.8 -m venv venv38
source venv38/bin/activate
pip install uv==0.4.11
source venv38/bin/activate  
# ^^ this repeat seemed necessary to point to the freshly-installed uv instead of the homebrew/system uv
uv pip install  --resolution lowest-direct --upgrade --editable '.[google]'

@topherinternational
Copy link
Contributor

I also quickly experimented with lower uv versions, it looks like uv 0.4.7 is the last version without this error (0.4.8 and above fail with the numpy error).

@dirrao dirrao changed the title uv version bump to 0.4.10 uv version bump to 0.4.13 Sep 20, 2024
@dirrao dirrao self-assigned this Sep 20, 2024
@dirrao dirrao changed the title uv version bump to 0.4.13 uv version bump to 0.4.7 Sep 21, 2024
@topherinternational
Copy link
Contributor

Based on my research, I think uv 0.4.8 has a regression that breaks a change they added, ironically, for Airflow.

astral-sh/uv#4149 closed astral-sh/uv#4136, which was requested by @potiuk. uv 0.4.8 included astral-sh/uv#7226, which I've confirmed is the breaking commit via bisect testing.

I'm going to file an issue on uv for this.

@topherinternational
Copy link
Contributor

@dirrao I think you'll want to merge/rebase main again to get #42451 to clear the static checks errors (the branch is fine, main was busted).

@vincbeck vincbeck merged commit ab5406e into apache:main Sep 25, 2024
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants