Avoid pre-fetching for unbounded minimum versions#4149
Merged
charliermarsh merged 2 commits intomainfrom Jun 7, 2024
Merged
Conversation
42ada63 to
2a1a357
Compare
zanieb
reviewed
Jun 7, 2024
zanieb
approved these changes
Jun 7, 2024
2a1a357 to
8058d2b
Compare
zanieb
reviewed
Jun 7, 2024
Comment on lines
+1406
to
+1408
| // Avoid prefetching source distributions with unbounded lower-bound ranges. This | ||
| // often leads to failed attempts to build legacy versions of packages that are | ||
| // incompatible with modern build tools. |
There was a problem hiding this comment.
Nice, simple solution to a non-simple problem. Let met confirm it works :)
This was referenced Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think we should be able to model PubGrub such that this isn't necessary (at least for the case described in the issue), but for now, let's just avoid attempting to build very old distributions in prefetching.
Closes #4136.