Add completions menu for files and folders #8
Conversation
|
will look at this first thing today; looks great! just to be clear, there are two features at play here: the @file/folder/symbol feature is a mechanism for explicitly adding content to the context (a la cursor, and others), is this that? or is this file path completion? both are great, we'd just want to switch to having the |
|
I modeled it more for the cursor like mechanism as you will see in the implementation, but since the view tool is able to pick up file paths just from the text it works like the latter for now. If needed I can add the file contents statically to the context as well. Whichever way you feel works best with the project. It can be / now and then when we add git or lsp support it can become @ with all the changes to ui that accompany adding another completion provider |
|
@Adictya this is incredible, seriously, thank you so much for going out of your way to make the codebase better. ❤️ my only two thoughts/questions:
|
|
Hey thanks a lot @adamdottv , it was a great experience. Always a joy to simplify code.
|
|
on the bubbles thing, you made the right call, and i suspected their list might not be configurable enough! your version is perfect, fits the needs of the app exactly |
|
@adamdottv Changed the initiation key to '/' |
…d dank Windows Command Execution Fixes: - Add detectCommandShell() and parseCommand() functions for shell detection - Implement direct PowerShell execution bypassing cmd.exe wrapper - Add shell built-ins detection and needsShellExecution function - Fix stream draining to prevent race conditions (Promise.all) - Remove duplicate abort listeners Edit Tool Improvements: - Add newString validation guard (handles undefined/null/empty) - Add UnicodeNormalizedReplacer for smart quotes and em-dashes - Fix multi-line pattern matching with empty lines (Issue anomalyco#26) - Add unique match identification for replaceFirst functionality - Improve block anchor matching with variable gap handling Documentation: - Add verified-fixes-summary.md documenting all fixed issues - Add windows-command-execution-issues.md comprehensive analysis - Add linux-unix-mac-compatibility-analysis.md for cross-platform impact Fixes: Issues anomalyco#2, anomalyco#3, anomalyco#4, anomalyco#5, anomalyco#7, anomalyco#8, anomalyco#9, anomalyco#15, anomalyco#19, anomalyco#26
Demo:
Adds completions menu for files and folders. You can press "@" to bring this up and fuzzy find any file in the working directory.
Built to be extensible so we can add more providers for things like git, lsp symbols etc given we also build the tools.
Adds a minimal reusable list component since I had found myself reusing a lot of code from commands dialog.
Let me know if this looks good and if the ux feels good and if its line with what you guys think this feature should look like. Also feel free to be as pedantic as you want, I want to strictly adhere to the repo coding style so if any naming/folder convention doesn't match or if any variable name is not ideal.