Skip to content

Conversation

@PhantomReactor
Copy link
Contributor

No description provided.

@adamdotdevin adamdotdevin merged commit ba416e7 into anomalyco:dev May 16, 2025
carabistouflette pushed a commit to carabistouflette/opencode that referenced this pull request Jun 16, 2025
burgercrisis added a commit to burgercrisis/opencode that referenced this pull request Jan 8, 2026
…d dank

Windows Command Execution Fixes:
- Add detectCommandShell() and parseCommand() functions for shell detection
- Implement direct PowerShell execution bypassing cmd.exe wrapper
- Add shell built-ins detection and needsShellExecution function
- Fix stream draining to prevent race conditions (Promise.all)
- Remove duplicate abort listeners

Edit Tool Improvements:
- Add newString validation guard (handles undefined/null/empty)
- Add UnicodeNormalizedReplacer for smart quotes and em-dashes
- Fix multi-line pattern matching with empty lines (Issue anomalyco#26)
- Add unique match identification for replaceFirst functionality
- Improve block anchor matching with variable gap handling

Documentation:
- Add verified-fixes-summary.md documenting all fixed issues
- Add windows-command-execution-issues.md comprehensive analysis
- Add linux-unix-mac-compatibility-analysis.md for cross-platform impact

Fixes: Issues anomalyco#2, anomalyco#3, anomalyco#4, anomalyco#5, anomalyco#7, anomalyco#8, anomalyco#9, anomalyco#15, anomalyco#19, anomalyco#26
randomm added a commit to randomm/opencode that referenced this pull request Jan 9, 2026
…ns (anomalyco#26)

BREAKING CHANGE: Replaces dual-container setup with unified container

Merges opencode_sandbox and opencode_with_ssh into single unified 
container accessible via both docker exec (Mac) and SSH (iPhone).

Major improvements:
- Single container with dual access (docker exec + SSH)
- Persistent screen sessions shared between devices
- Smart helper script (scripts/opencode) auto-attaches or creates
- GitHub CLI available from all access methods
- Docker socket access for MCP servers
- Dynamic Docker GID detection (cross-platform compatible)
- Robust screen session initialization (no race conditions)

Components added:
- Dockerfile.opencode-unified (merged features from both old Dockerfiles)
- docker-compose.yml (unified compose with Tailscale sidecar)
- entrypoint-unified.sh (SSH daemon + gh auth + screen session)
- scripts/opencode (smart launcher with attach logic)
- .screenrc (persistent session config)
- docs/session-management.md (usage guide)
- MIGRATION.md (upgrade guide)
- tests/test_unified_container.bats (test suite)

Review process:
- Initial review: 7 issues found (3 critical, 4 major)
- Fixes applied in f1a7b7d
- Re-review: All issues verified fixed, APPROVED

Closes anomalyco#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants