feat(app): bring v2 visibility settings to web#32174
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the v2 “visibility” preferences (file tree, navigation controls, command palette/search, terminal, server status, and custom agents) behave consistently across web and desktop by centralizing the “is this feature visible in v2?” logic in the settings context, while keeping legacy (non-v2) behavior unchanged.
Changes:
- Introduces a
settings.visibilitypolicy that gates advanced UI elements based onnewLayoutDesigns+ the existing advanced preferences. - Replaces platform-specific v2 checks in session/titlebar/composer code with the shared
settings.visibility.*accessors. - Exposes the Advanced section in v2 settings on web and updates EN/UK descriptions to remove desktop-only wording.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/app/src/context/settings.tsx | Adds centralized visibility accessors derived from newLayoutDesigns and existing “showX” preferences. |
| packages/app/src/pages/session/use-session-commands.tsx | Uses settings.visibility.fileTree/customAgents to control file tree commands and agent cycling enablement. |
| packages/app/src/pages/session/session-side-panel.tsx | Uses settings.visibility.fileTree to determine whether the file tree panel can be shown. |
| packages/app/src/pages/session/helpers.ts | Simplifies shouldShowFileTree to opened && visible. |
| packages/app/src/pages/session/helpers.test.ts | Updates unit test to reflect new shouldShowFileTree signature/behavior. |
| packages/app/src/pages/session.tsx | Routes file tree visibility through settings.visibility.fileTree(). |
| packages/app/src/components/titlebar.tsx | Uses settings.visibility.navigation for navigation controls visibility under v2. |
| packages/app/src/components/settings-v2/general.tsx | Renders AdvancedSection on all platforms (including web). |
| packages/app/src/components/session/session-header.tsx | Uses settings.visibility for search/tree/terminal/status controls instead of desktop-only gating. |
| packages/app/src/components/prompt-input.tsx | Uses settings.visibility.customAgents() to show/hide agent picker controls consistently. |
| packages/app/src/i18n/en.ts | Removes desktop-specific wording from advanced preference descriptions (and clarifies custom agents). |
| packages/app/src/i18n/uk.ts | Removes desktop-specific wording from advanced preference descriptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danzeroum
added a commit
to danzeroum/opencode
that referenced
this pull request
Jun 13, 2026
… docs (#4) * fix(app): fade overflowing titlebar tabs (anomalyco#32082) * chore: generate * fix(app): expand terminal resize gutter hitbox (anomalyco#32169) * feat(app): bring v2 visibility settings to web (anomalyco#32174) * fix(opencode): recover expired MCP sessions (anomalyco#32088) * chore: update nix node_modules hashes * feat(opencode): add external browser OAuth for snowflake cortex provider (anomalyco#31700) Co-authored-by: santiago.gonzalezcarvajcentenera <santiago.gonzalezcarvajcentenera@colaborador.elcorteingles.es> Co-authored-by: David Fierro <14184197+davidfierro@users.noreply.github.com> Co-authored-by: Kamesh Sampath <kamesh.sampath@hotmail.com> Co-authored-by: Cortex Code <noreply@snowflake.com> * chore: generate * docs(verify): note subtask side-effects; add frontmatter table + http-recorder guidance * feat(core): add opt-in EventV2 event log and decision.recorded event --------- Co-authored-by: Luke Parker <10430890+Hona@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Co-authored-by: santigc6 <santigc6@users.noreply.github.com> Co-authored-by: santiago.gonzalezcarvajcentenera <santiago.gonzalezcarvajcentenera@colaborador.elcorteingles.es> Co-authored-by: David Fierro <14184197+davidfierro@users.noreply.github.com> Co-authored-by: Kamesh Sampath <kamesh.sampath@hotmail.com> Co-authored-by: Cortex Code <noreply@snowflake.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR;
Changelog
Added
Fixed
Removed
Legacy settings and behavior are unchanged.
Closes #32026
Closes #31845