fix(app): expand terminal resize gutter hitbox#32169
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the session terminal panel layout so the vertical resize handle’s hitbox spans the full visible gutter (instead of being clipped inside the panel), and adds a Playwright regression test to ensure the gutter pixels consistently hit the resize handle.
Changes:
- Move the terminal resize handle onto an outer layer so it can extend into the gutter while keeping terminal content clipped on an inner layer.
- Shift border/clipping responsibilities to the inner terminal layer to preserve visuals while allowing overflow for the handle.
- Add an e2e regression test asserting all 8 gutter pixels hit the resize handle.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/app/src/pages/session/terminal-panel.tsx | Re-layers the terminal panel so the resize handle can extend into the gutter without clipping terminal content. |
| packages/app/e2e/regression/terminal-resize-hitbox.spec.ts | Adds a Playwright regression test verifying the full 8px gutter area targets the resize handle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }} | ||
| style={{ height: opened() ? `${pane()}px` : "0px" }} | ||
| > | ||
| <div class="hidden md:block" onPointerDown={() => size.start()}> |
Comment on lines
+53
to
+62
| return { | ||
| top: handleBox.top - panelBox.top, | ||
| bottom: handleBox.bottom - panelBox.top, | ||
| pixels: Array.from({ length: 8 }, (_, offset) => offset - 7.5).map( | ||
| (offset) => | ||
| document | ||
| .elementFromPoint(handleBox.left + handleBox.width / 2, panelBox.top + offset) | ||
| ?.getAttribute("data-component") === "resize-handle", | ||
| ), | ||
| } |
Comment on lines
+72
to
+74
| function base64Encode(value: string) { | ||
| return btoa(value).replaceAll("+", "-").replaceAll("/", "_").replaceAll("=", "") | ||
| } |
danzeroum
added a commit
to danzeroum/opencode
that referenced
this pull request
Jun 13, 2026
… docs (#4) * fix(app): fade overflowing titlebar tabs (anomalyco#32082) * chore: generate * fix(app): expand terminal resize gutter hitbox (anomalyco#32169) * feat(app): bring v2 visibility settings to web (anomalyco#32174) * fix(opencode): recover expired MCP sessions (anomalyco#32088) * chore: update nix node_modules hashes * feat(opencode): add external browser OAuth for snowflake cortex provider (anomalyco#31700) Co-authored-by: santiago.gonzalezcarvajcentenera <santiago.gonzalezcarvajcentenera@colaborador.elcorteingles.es> Co-authored-by: David Fierro <14184197+davidfierro@users.noreply.github.com> Co-authored-by: Kamesh Sampath <kamesh.sampath@hotmail.com> Co-authored-by: Cortex Code <noreply@snowflake.com> * chore: generate * docs(verify): note subtask side-effects; add frontmatter table + http-recorder guidance * feat(core): add opt-in EventV2 event log and decision.recorded event --------- Co-authored-by: Luke Parker <10430890+Hona@users.noreply.github.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Co-authored-by: santigc6 <santigc6@users.noreply.github.com> Co-authored-by: santiago.gonzalezcarvajcentenera <santiago.gonzalezcarvajcentenera@colaborador.elcorteingles.es> Co-authored-by: David Fierro <14184197+davidfierro@users.noreply.github.com> Co-authored-by: Kamesh Sampath <kamesh.sampath@hotmail.com> Co-authored-by: Cortex Code <noreply@snowflake.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
PLAYWRIGHT_PORT=3012 bunx playwright test e2e/regression/terminal-resize-hitbox.spec.ts --project=chromiumbun typecheckrow-resizeand dragging from the gutter resizes the terminal