Fix tests, add '.' and '!' to kwdopchar#2
Merged
anmonteiro merged 3 commits intoanmonteiro:anmonteiro/ocaml-408from Nov 27, 2019
Merged
Fix tests, add '.' and '!' to kwdopchar#2anmonteiro merged 3 commits intoanmonteiro:anmonteiro/ocaml-408from
anmonteiro merged 3 commits intoanmonteiro:anmonteiro/ocaml-408from
Conversation
Back in the "async await" discussions in reason land, there were vigorous proponents of both the "let." and "let!", so I figure I might as well add them here :)
anmonteiro
reviewed
Nov 27, 2019
| @@ -0,0 +1,16 @@ | |||
| let (let.opt) = (x, f) => | |||
Owner
There was a problem hiding this comment.
wait, why can't we put this on the other file too?
Author
There was a problem hiding this comment.
because it's not valid ocaml syntax :)
Author
|
ugh the tests are failing because a newline is different 🙃 |
Owner
|
I tried to fix it on the Reason PR |
anmonteiro
pushed a commit
that referenced
this pull request
Jan 21, 2020
Back in the "async await" discussions in reason land, there were vigorous proponents of both the "let." and "let!", so I figure I might as well add them here :)
anmonteiro
pushed a commit
that referenced
this pull request
Feb 11, 2020
Back in the "async await" discussions in reason land, there were vigorous proponents of both the "let." and "let!", so I figure I might as well add them here :)
anmonteiro
added a commit
that referenced
this pull request
Mar 31, 2020
* Upgrade Parser to 4.08 AST and add 4.08 features * fix exception tests * Support alphanumeric characters in the monadic syntax (#1) * Fix tests, add '.' and '!' to kwdopchar (#2) Back in the "async await" discussions in reason land, there were vigorous proponents of both the "let." and "let!", so I figure I might as well add them here :) * newline, really? * fix test * Backport `letop` monadic let syntax to pre-4.08 (making it bucklescript compatible!) (#3) * fix some warnings * apply mappers when printing to AST and ML * fix binding ops interaction with comment chars * Set correct location end position in letop binding parsing * Add test for @supriyo's fix * Fix syntax util for new AST * pin dune to 1.x * update lock files Co-authored-by: Jared Forsyth <jabapyth@gmail.com> Co-authored-by: Supriyo Sinha <supriyo@typeish.net> Co-authored-by: Sikan He <sikanhe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in the "async await" discussions in reason land, there were vigorous proponents of both the "let." and "let!", so I figure I might as well add them here :)