Skip to content

Support alphanumeric characters in the monadic syntax#1

Merged
anmonteiro merged 1 commit intoanmonteiro:anmonteiro/ocaml-408from
jaredly:let+better
Nov 26, 2019
Merged

Support alphanumeric characters in the monadic syntax#1
anmonteiro merged 1 commit intoanmonteiro:anmonteiro/ocaml-408from
jaredly:let+better

Conversation

@jaredly
Copy link
Copy Markdown

@jaredly jaredly commented Nov 26, 2019

It seemed to compile just fine :) so no conflicts I think?

@anmonteiro
Copy link
Copy Markdown
Owner

I love it.

@anmonteiro
Copy link
Copy Markdown
Owner

Let's try it out on the reason CI

@anmonteiro anmonteiro merged commit 8868990 into anmonteiro:anmonteiro/ocaml-408 Nov 26, 2019
anmonteiro added a commit that referenced this pull request Mar 31, 2020
* Upgrade Parser to 4.08 AST and add 4.08 features

* fix exception tests

* Support alphanumeric characters in the monadic syntax (#1)

* Fix tests, add '.' and '!' to kwdopchar (#2)

Back in the "async await" discussions in reason land, there were vigorous proponents of both the "let." and "let!", so I figure I might as well add them here :)

* newline, really?

* fix test

* Backport `letop` monadic let syntax to pre-4.08 (making it bucklescript compatible!) (#3)

* fix some warnings

* apply mappers when printing to AST and ML

* fix binding ops interaction with comment chars

* Set correct location end position in letop binding parsing

* Add test for @supriyo's fix

* Fix syntax util for new AST

* pin dune to 1.x

* update lock files

Co-authored-by: Jared Forsyth <jabapyth@gmail.com>
Co-authored-by: Supriyo Sinha <supriyo@typeish.net>
Co-authored-by: Sikan He <sikanhe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants