refactor(compiler-cli): include linkedSignal in the signal debugName transformer#64106
Closed
hawkgs wants to merge 1 commit intoangular:mainfrom
Closed
refactor(compiler-cli): include linkedSignal in the signal debugName transformer#64106hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
approved these changes
Sep 26, 2025
…transformer Add support for `linkedSignal`s in the signal `debugName` transformer. Continuation of angular#63346
3327202 to
1c51b40
Compare
kirjs
approved these changes
Sep 29, 2025
Contributor
napulitanfrontend
pushed a commit
to napulitanfrontend/angular
that referenced
this pull request
Oct 10, 2025
…transformer (angular#64106) Add support for `linkedSignal`s in the signal `debugName` transformer. Continuation of angular#63346 PR Close angular#64106
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #63346 addresses the lack of
debugNameinlinkedSignal's options, it seems that we are missing a transformer that adds thatdebugNameto the source files.The change introduces a special case to the general-purpose signal transformer. This is not ideal (rather the quickest solution) and I've been thinking that maybe we should consider updating the design of that transformer to something more strategy-oriented since the reactivity API is evolving.
On another note, it might be good to add some tests.