refactor(core): improve linkedSignal type definitions, add debugName#63346
Closed
Avcharov wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): improve linkedSignal type definitions, add debugName#63346Avcharov wants to merge 1 commit intoangular:mainfrom
Avcharov wants to merge 1 commit intoangular:mainfrom
Conversation
Member
|
This change looks fine to me, we'll also need to update the golden files with |
14 tasks
4a76fda to
210c6f6
Compare
JeanMeche
reviewed
Aug 28, 2025
210c6f6 to
9f15010
Compare
9f15010 to
b3ae76f
Compare
We'd like to discuss some details internally first. (Like do we want an additional interface).
JeanMeche
reviewed
Sep 17, 2025
…to options Add debugName for having ability to visualize linkedSignal name in devtools signal graph
b3ae76f to
3f5360d
Compare
thePunderWoman
approved these changes
Sep 23, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM
reviewed-for: fw-general, public-api
Contributor
hawkgs
added a commit
to hawkgs/angular
that referenced
this pull request
Sep 26, 2025
…sformer Add support for `linkedSignal`s in the signal `debugName` transformer. Continuation of angular#63346
hawkgs
added a commit
to hawkgs/angular
that referenced
this pull request
Sep 26, 2025
…transformer Add support for `linkedSignal`s in the signal `debugName` transformer. Continuation of angular#63346
napulitanfrontend
pushed a commit
to napulitanfrontend/angular
that referenced
this pull request
Oct 10, 2025
…transformer (angular#64106) Add support for `linkedSignal`s in the signal `debugName` transformer. Continuation of angular#63346 PR Close angular#64106
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add debugName for having ability to visualize linkedSignal name in devtools signal graph
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
all LinkedSignals has "Unnamed" name in devtools signal graph(red)
What is the new behavior?
It is possible to specify debugName
Does this PR introduce a breaking change?