fix(migrations): handle import aliases to the same module name#63934
Closed
mattlewis92 wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): handle import aliases to the same module name#63934mattlewis92 wants to merge 1 commit intoangular:mainfrom
mattlewis92 wants to merge 1 commit intoangular:mainfrom
Conversation
Fixes a bug in the standalone migration where 2 imported modules have the same class name but 1 is imported with an alias and would not be added to the component imports array when migrating Fixes angular#63913
joshbeckerleg-clickup
approved these changes
Sep 19, 2025
Contributor
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 19, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If a module imports 2 modules with the same name but one with an alias, the aliased one is not added to the component imports array
e.g. when migrating this component:
The component imports array is set to:
Issue Number: #63913
What is the new behavior?
When migrating the example above, the component imports array is set to:
Does this PR introduce a breaking change?
Other information