fix(migrations): handle import aliases to the same module name (#63934)

mattlewis92 · thePunderWoman · commit 16d0d43ad490 · 2025-09-19T14:48:33.000Z
Fixes a bug in the standalone migration where 2 imported modules have the same class name but 1 is imported with an alias and would not be added to the component imports array when migrating Fixes #63913 PR Close #63934
diff --git a/packages/core/schematics/ng-generate/standalone-migration/to-standalone.ts b/packages/core/schematics/ng-generate/standalone-migration/to-standalone.ts
@@ -194,9 +194,17 @@ function getComponentImportExpressions(
       typeChecker,
     );
 
-    if (importLocation && !seenImports.has(importLocation.symbolName)) {
-      seenImports.add(importLocation.symbolName);
-      resolvedDependencies.push(importLocation);
+    if (importLocation) {
+      // Create a unique key that includes both the symbol name and module specifier
+      // to handle cases where the same symbol name is imported from different modules
+      const importKey = importLocation.moduleSpecifier
+        ? `${importLocation.symbolName}::${importLocation.moduleSpecifier}`
+        : importLocation.symbolName;
+
+      if (!seenImports.has(importKey)) {
+        seenImports.add(importKey);
+        resolvedDependencies.push(importLocation);
+      }
     }
   }
 
diff --git a/packages/core/schematics/test/standalone_migration_spec.ts b/packages/core/schematics/test/standalone_migration_spec.ts
@@ -5037,4 +5037,90 @@ describe('standalone migration', () => {
     `),
     );
   });
+
+  it('should add handle import aliases to the same module name', async () => {
+    writeFile(
+      './app/comp.ts',
+      `
+      import { Component, NgModule } from '@angular/core';
+      import { AnotherModule } from '../another/another';
+      import { AnotherModule as LegacyAnotherModule } from '../another/another-legacy';
+
+      @Component({
+        selector: 'my-comp',
+        template: '<another1 /> <another2 />',
+        standalone: false
+      })
+      export class MyComponent {}
+
+      @NgModule({
+        imports: [AnotherModule, LegacyAnotherModule],
+        declarations: [MyComponent],
+        exports: [MyComponent]
+      })
+      export class MyModule {}
+
+    `,
+    );
+
+    writeFile(
+      './another/another.ts',
+      `
+      import { Component, NgModule } from '@angular/core';
+
+      @Component({
+        selector: 'another1',
+        template: 'another1',
+        standalone: false
+      })
+      export class AnotherComponent {}
+
+      @NgModule({
+        declarations: [AnotherComponent],
+        exports: [AnotherComponent]
+      })
+      export class AnotherModule {}
+
+    `,
+    );
+
+    writeFile(
+      './another/another-legacy.ts',
+      `
+      import { Component, NgModule } from '@angular/core';
+
+      @Component({
+        selector: 'another2',
+        template: 'another2',
+        standalone: false
+      })
+      export class AnotherComponent {}
+
+      @NgModule({
+        declarations: [AnotherComponent],
+        exports: [AnotherComponent]
+      })
+      export class AnotherModule {}
+
+    `,
+    );
+
+    await runMigration('convert-to-standalone', './app/');
+
+    const myCompContent = tree.readContent('app/comp.ts');
+
+    expect(myCompContent).toContain(`import { AnotherModule } from '../another/another';`);
+    expect(myCompContent).toContain(
+      `import { AnotherModule as LegacyAnotherModule } from '../another/another-legacy';`,
+    );
+    expect(stripWhitespace(myCompContent)).toContain(
+      stripWhitespace(`
+      @Component({
+        selector: 'my-comp',
+        template: '<another1 /> <another2 />',
+        imports: [AnotherModule, LegacyAnotherModule]
+      })
+    `),
+    );
+  });
 });
