refactor(core): wrap checkNoChanges body in if (ngDevMode) for better tree-shaking#63387
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): wrap checkNoChanges body in if (ngDevMode) for better tree-shaking#63387arturovt wants to merge 1 commit intoangular:mainfrom
checkNoChanges body in if (ngDevMode) for better tree-shaking#63387arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
reviewed
Aug 26, 2025
4a5ad38 to
1579f28
Compare
…tter tree-shaking
The `checkNoChanges` method previously used an early-return guard:
if (!ngDevMode) return;
// dev-only code ...
In production builds, `ngDevMode` is replaced with `false`, so the
guard compiles to `return;`. However, bundlers like ESBuild
still keep the remaining statements after the return as unreachable
code instead of removing them. This leaves behind unnecessary dead
code in the output.
This commit updates the method to instead wrap the full body:
if (ngDevMode) {
// dev-only code ...
}
With this change, the method collapses to an empty function in
production builds:
checkNoChanges() {}
This ensures that the dev-only logic and its dependencies
(e.g. `checkNoChangesInternal`, `UseExhaustiveCheckNoChanges`) can be
fully tree-shaken, reducing bundle size.
1579f28 to
68f5eb2
Compare
JeanMeche
approved these changes
Sep 1, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 15, 2025
…tter tree-shaking (#63387) The `checkNoChanges` method previously used an early-return guard: if (!ngDevMode) return; // dev-only code ... In production builds, `ngDevMode` is replaced with `false`, so the guard compiles to `return;`. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output. This commit updates the method to instead wrap the full body: if (ngDevMode) { // dev-only code ... } With this change, the method collapses to an empty function in production builds: checkNoChanges() {} This ensures that the dev-only logic and its dependencies (e.g. `checkNoChangesInternal`, `UseExhaustiveCheckNoChanges`) can be fully tree-shaken, reducing bundle size. PR Close #63387
Contributor
wildcardalice
pushed a commit
to wildcardalice/angular
that referenced
this pull request
Sep 18, 2025
…tter tree-shaking (angular#63387) The `checkNoChanges` method previously used an early-return guard: if (!ngDevMode) return; // dev-only code ... In production builds, `ngDevMode` is replaced with `false`, so the guard compiles to `return;`. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output. This commit updates the method to instead wrap the full body: if (ngDevMode) { // dev-only code ... } With this change, the method collapses to an empty function in production builds: checkNoChanges() {} This ensures that the dev-only logic and its dependencies (e.g. `checkNoChangesInternal`, `UseExhaustiveCheckNoChanges`) can be fully tree-shaken, reducing bundle size. PR Close angular#63387
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
checkNoChangesmethod previously used an early-return guard:In production builds,
ngDevModeis replaced withfalse, so the guard compiles toreturn;. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output.Technically, the body is unreachable. But to prove that, the bundler must be 100% certain that:
returncannot be removed by some transformAs thus, it's always conservative.
This commit updates the method to instead wrap the full body:
With this change, the method collapses to an empty function in production builds.
This ensures that the dev-only logic and its dependencies (e.g.
checkNoChangesInternal,UseExhaustiveCheckNoChanges) can be fully tree-shaken, reducing bundle size.