Skip to content

Commit 4a23f6e

Browse files
arturovtthePunderWoman
arturovt
authored and
thePunderWoman
committed
refactor(core): wrap checkNoChanges body in if (ngDevMode) for better tree-shaking (#63387)
The `checkNoChanges` method previously used an early-return guard: if (!ngDevMode) return; // dev-only code ... In production builds, `ngDevMode` is replaced with `false`, so the guard compiles to `return;`. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output. This commit updates the method to instead wrap the full body: if (ngDevMode) { // dev-only code ... } With this change, the method collapses to an empty function in production builds: checkNoChanges() {} This ensures that the dev-only logic and its dependencies (e.g. `checkNoChangesInternal`, `UseExhaustiveCheckNoChanges`) can be fully tree-shaken, reducing bundle size. PR Close #63387
1 parent 19462fc commit 4a23f6e

File tree

8 files changed

+15
-52
lines changed

8 files changed

+15
-52
lines changed

‎packages/core/src/render3/view_ref.ts‎

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -328,17 +328,22 @@ export class ViewRef<T> implements EmbeddedViewRef<T>, ChangeDetectorRefInterfac
328328
* introduce other changes.
329329
*/
330330
checkNoChanges(): void {
331-
if (!ngDevMode) return;
332-
333-
try {
334-
this.exhaustive ??= this._lView[INJECTOR].get(
335-
UseExhaustiveCheckNoChanges,
336-
USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT,
337-
);
338-
} catch {
339-
this.exhaustive = USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT;
331+
// Note: we use `if (ngDevMode) { ... }` instead of an early return.
332+
// ESBuild is conservative about removing dead code that follows `return;`
333+
// inside a function body, so the block may remain in the bundle.
334+
// Using a conditional ensures the dev-only logic is reliably tree-shaken
335+
// in production builds.
336+
if (ngDevMode) {
337+
try {
338+
this.exhaustive ??= this._lView[INJECTOR].get(
339+
UseExhaustiveCheckNoChanges,
340+
USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT,
341+
);
342+
} catch {
343+
this.exhaustive = USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT;
344+
}
345+
checkNoChangesInternal(this._lView, this.exhaustive);
340346
}
341-
checkNoChangesInternal(this._lView, this.exhaustive);
342347
}
343348

344349
attachToViewContainerRef() {

‎packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
"ChangeDetectionScheduler",
5858
"ChangeDetectionSchedulerImpl",
5959
"ChangeDetectionStrategy",
60-
"CheckNoChangesMode",
6160
"ComponentFactory",
6261
"ComponentFactory",
6362
"ComponentFactoryResolver",
@@ -260,10 +259,8 @@
260259
"TracingService",
261260
"TransitionAnimationEngine",
262261
"TransitionAnimationPlayer",
263-
"USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT",
264262
"USE_VALUE",
265263
"UnsubscriptionError",
266-
"UseExhaustiveCheckNoChanges",
267264
"VIEW_REFS",
268265
"VOID_VALUE",
269266
"ViewEncapsulation",
@@ -381,7 +378,6 @@
381378
"_applyRootElementTransformImpl",
382379
"_bind",
383380
"_callAndReportToErrorHandler",
384-
"_checkNoChangesMode",
385381
"_convertTimeValueToMS",
386382
"_currentInjector",
387383
"_document",
@@ -443,7 +439,6 @@
443439
"callHookInternal",
444440
"callHooks",
445441
"captureError",
446-
"checkNoChangesInternal",
447442
"checkStable",
448443
"classIndexOf",
449444
"cleanUpView",
@@ -888,7 +883,6 @@
888883
"setIncludeViewProviders",
889884
"setInjectImplementation",
890885
"setInputsFromAttrs",
891-
"setIsInCheckNoChangesMode",
892886
"setIsRefreshingViews",
893887
"setLocaleId",
894888
"setPropertyAndInputs",

‎packages/core/test/bundling/defer/bundle.golden_symbols.json‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@
9494
"ChangeDetectionScheduler",
9595
"ChangeDetectionSchedulerImpl",
9696
"ChangeDetectionStrategy",
97-
"CheckNoChangesMode",
9897
"ComponentFactory",
9998
"ComponentFactory",
10099
"ComponentFactoryResolver",
@@ -247,10 +246,8 @@
247246
"T_HOST",
248247
"TracingAction",
249248
"TracingService",
250-
"USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT",
251249
"USE_VALUE",
252250
"UnsubscriptionError",
253-
"UseExhaustiveCheckNoChanges",
254251
"VIEW_REFS",
255252
"ViewEncapsulation",
256253
"ViewRef",
@@ -325,7 +322,6 @@
325322
"_applyRootElementTransformImpl",
326323
"_bind",
327324
"_callAndReportToErrorHandler",
328-
"_checkNoChangesMode",
329325
"_currentInjector",
330326
"_getInsertInFrontOfRNodeWithI18n",
331327
"_icuContainerIterate",
@@ -378,7 +374,6 @@
378374
"callHookInternal",
379375
"callHooks",
380376
"captureError",
381-
"checkNoChangesInternal",
382377
"checkStable",
383378
"classIndexOf",
384379
"cleanUpView",
@@ -754,7 +749,6 @@
754749
"setIncludeViewProviders",
755750
"setInjectImplementation",
756751
"setInputsFromAttrs",
757-
"setIsInCheckNoChangesMode",
758752
"setIsRefreshingViews",
759753
"setLDeferBlockDetails",
760754
"setLocaleId",

‎packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
"ChangeDetectionScheduler",
5050
"ChangeDetectionSchedulerImpl",
5151
"ChangeDetectionStrategy",
52-
"CheckNoChangesMode",
5352
"CheckboxControlValueAccessor",
5453
"CommonModule",
5554
"ComponentFactory",
@@ -260,10 +259,8 @@
260259
"TracingAction",
261260
"TracingService",
262261
"UNSET",
263-
"USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT",
264262
"USE_VALUE",
265263
"UnsubscriptionError",
266-
"UseExhaustiveCheckNoChanges",
267264
"VALID",
268265
"VE_ViewContainerRef",
269266
"VIEW_REFS",
@@ -403,7 +400,6 @@
403400
"_arrayIndexOfSorted",
404401
"_bind",
405402
"_callAndReportToErrorHandler",
406-
"_checkNoChangesMode",
407403
"_currentInjector",
408404
"_document",
409405
"_findMatchingDehydratedViewImpl",
@@ -475,7 +471,6 @@
475471
"callHooks",
476472
"callOrApply",
477473
"captureError",
478-
"checkNoChangesInternal",
479474
"checkStable",
480475
"checkStylingProperty",
481476
"classIndexOf",
@@ -1026,7 +1021,6 @@
10261021
"setIncludeViewProviders",
10271022
"setInjectImplementation",
10281023
"setInputsFromAttrs",
1029-
"setIsInCheckNoChangesMode",
10301024
"setIsRefreshingViews",
10311025
"setJitOptions",
10321026
"setLocaleId",

‎packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
"ChangeDetectionSchedulerImpl",
5252
"ChangeDetectionStrategy",
5353
"ChangeDetectorRef",
54-
"CheckNoChangesMode",
5554
"CheckboxControlValueAccessor",
5655
"CommonModule",
5756
"ComponentFactory",
@@ -258,10 +257,8 @@
258257
"TracingAction",
259258
"TracingService",
260259
"UNSET",
261-
"USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT",
262260
"USE_VALUE",
263261
"UnsubscriptionError",
264-
"UseExhaustiveCheckNoChanges",
265262
"VALID",
266263
"VE_ViewContainerRef",
267264
"VIEW_REFS",
@@ -405,7 +402,6 @@
405402
"_arrayIndexOfSorted",
406403
"_bind",
407404
"_callAndReportToErrorHandler",
408-
"_checkNoChangesMode",
409405
"_currentInjector",
410406
"_document",
411407
"_findMatchingDehydratedViewImpl",
@@ -478,7 +474,6 @@
478474
"callHooks",
479475
"callOrApply",
480476
"captureError",
481-
"checkNoChangesInternal",
482477
"checkStable",
483478
"checkStylingProperty",
484479
"classIndexOf",
@@ -1023,7 +1018,6 @@
10231018
"setIncludeViewProviders",
10241019
"setInjectImplementation",
10251020
"setInputsFromAttrs",
1026-
"setIsInCheckNoChangesMode",
10271021
"setIsRefreshingViews",
10281022
"setJitOptions",
10291023
"setLocaleId",

‎packages/core/test/bundling/hydration/bundle.golden_symbols.json‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"ChangeDetectionScheduler",
4343
"ChangeDetectionSchedulerImpl",
4444
"ChangeDetectionStrategy",
45-
"CheckNoChangesMode",
4645
"ComponentFactory",
4746
"ComponentFactory",
4847
"ComponentFactoryResolver",
@@ -228,10 +227,8 @@
228227
"TracingAction",
229228
"TracingService",
230229
"TransferState",
231-
"USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT",
232230
"USE_VALUE",
233231
"UnsubscriptionError",
234-
"UseExhaustiveCheckNoChanges",
235232
"VIEW_REFS",
236233
"ViewEncapsulation",
237234
"ViewRef",
@@ -320,7 +317,6 @@
320317
"_applyRootElementTransformImpl",
321318
"_bind",
322319
"_callAndReportToErrorHandler",
323-
"_checkNoChangesMode",
324320
"_currentInjector",
325321
"_document",
326322
"_findAndReconcileMatchingDehydratedViewsImpl",
@@ -379,7 +375,6 @@
379375
"callHooks",
380376
"canHydrateNode",
381377
"captureError",
382-
"checkNoChangesInternal",
383378
"checkStable",
384379
"cleanUpView",
385380
"cleanupDehydratedIcuData",
@@ -805,7 +800,6 @@
805800
"setInjectImplementation",
806801
"setInputsFromAttrs",
807802
"setIsI18nHydrationSupportEnabled",
808-
"setIsInCheckNoChangesMode",
809803
"setIsRefreshingViews",
810804
"setLocaleId",
811805
"setRootDomAdapter",

‎packages/core/test/bundling/router/bundle.golden_symbols.json‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"ChangeDetectionSchedulerImpl",
5151
"ChangeDetectionStrategy",
5252
"ChangeDetectorRef",
53-
"CheckNoChangesMode",
5453
"ChildActivationEnd",
5554
"ChildActivationStart",
5655
"ChildrenOutletContexts",
@@ -304,7 +303,6 @@
304303
"TracingService",
305304
"Tree",
306305
"TreeNode",
307-
"USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT",
308306
"USE_VALUE",
309307
"UnsubscriptionError",
310308
"UrlHandlingStrategy",
@@ -313,7 +311,6 @@
313311
"UrlSegmentGroup",
314312
"UrlSerializer",
315313
"UrlTree",
316-
"UseExhaustiveCheckNoChanges",
317314
"VE_ViewContainerRef",
318315
"VIEW_REFS",
319316
"ViewContainerRef",
@@ -480,7 +477,6 @@
480477
"_applyRootElementTransformImpl",
481478
"_bind",
482479
"_callAndReportToErrorHandler",
483-
"_checkNoChangesMode",
484480
"_currentInjector",
485481
"_document",
486482
"_findMatchingDehydratedViewImpl",
@@ -553,7 +549,6 @@
553549
"captureError",
554550
"catchError",
555551
"checkGuards",
556-
"checkNoChangesInternal",
557552
"checkStable",
558553
"classIndexOf",
559554
"cleanUpView",
@@ -1174,7 +1169,6 @@
11741169
"setIncludeViewProviders",
11751170
"setInjectImplementation",
11761171
"setInputsFromAttrs",
1177-
"setIsInCheckNoChangesMode",
11781172
"setIsRefreshingViews",
11791173
"setLocaleId",
11801174
"setRootDomAdapter",

‎packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
"ChangeDetectionScheduler",
3535
"ChangeDetectionSchedulerImpl",
3636
"ChangeDetectionStrategy",
37-
"CheckNoChangesMode",
3837
"ComponentFactory",
3938
"ComponentFactory",
4039
"ComponentFactoryResolver",
@@ -187,10 +186,8 @@
187186
"T_HOST",
188187
"TracingAction",
189188
"TracingService",
190-
"USE_EXHAUSTIVE_CHECK_NO_CHANGES_DEFAULT",
191189
"USE_VALUE",
192190
"UnsubscriptionError",
193-
"UseExhaustiveCheckNoChanges",
194191
"VIEW_REFS",
195192
"ViewEncapsulation",
196193
"ViewRef",
@@ -267,7 +264,6 @@
267264
"_applyRootElementTransformImpl",
268265
"_bind",
269266
"_callAndReportToErrorHandler",
270-
"_checkNoChangesMode",
271267
"_currentInjector",
272268
"_document",
273269
"_getInsertInFrontOfRNodeWithI18n",
@@ -315,7 +311,6 @@
315311
"callHookInternal",
316312
"callHooks",
317313
"captureError",
318-
"checkNoChangesInternal",
319314
"checkStable",
320315
"cleanUpView",
321316
"collectNativeNodes",
@@ -645,7 +640,6 @@
645640
"setIncludeViewProviders",
646641
"setInjectImplementation",
647642
"setInputsFromAttrs",
648-
"setIsInCheckNoChangesMode",
649643
"setIsRefreshingViews",
650644
"setLocaleId",
651645
"setRootDomAdapter",

0 commit comments

Comments
 (0)