refactor(core): swap dev/prod error handling order in injector for tree-shaking#63354
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): swap dev/prod error handling order in injector for tree-shaking#63354arturovt wants to merge 1 commit intoangular:mainfrom
arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
Member
|
Do you have an esbuild issue reference for why this isn't removed by tree shaking ? |
Contributor
Author
Member
|
What if we moved |
Contributor
Author
|
Nope, I tried it :( |
…ee-shaking In production builds, `ngDevMode` is replaced with `false`, so the guard compiles to `return;`. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output. Technically, the body is unreachable. But to prove that, the bundler must be 100% certain that: - `return` cannot be removed by some transform - there's no later transformation that changes control flow As thus, it's always conservative. This also allows dropping `assertDefined`, which was previously referenced only inside `prependTokenToDependencyPath`. With the function now fully inlined and dev-only, `assertDefined` is also eliminated from production builds, further reducing bundle size.
c0792d8 to
e8c0d5a
Compare
prependTokenToDependencyPath to enable tree-shaking
Contributor
Author
|
@JeanMeche I re-worked it and removed an early return, should be looking better now |
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 16, 2025
…ee-shaking (#63354) In production builds, `ngDevMode` is replaced with `false`, so the guard compiles to `return;`. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output. Technically, the body is unreachable. But to prove that, the bundler must be 100% certain that: - `return` cannot be removed by some transform - there's no later transformation that changes control flow As thus, it's always conservative. This also allows dropping `assertDefined`, which was previously referenced only inside `prependTokenToDependencyPath`. With the function now fully inlined and dev-only, `assertDefined` is also eliminated from production builds, further reducing bundle size. PR Close #63354
Contributor
wildcardalice
pushed a commit
to wildcardalice/angular
that referenced
this pull request
Sep 18, 2025
…ee-shaking (angular#63354) In production builds, `ngDevMode` is replaced with `false`, so the guard compiles to `return;`. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output. Technically, the body is unreachable. But to prove that, the bundler must be 100% certain that: - `return` cannot be removed by some transform - there's no later transformation that changes control flow As thus, it's always conservative. This also allows dropping `assertDefined`, which was previously referenced only inside `prependTokenToDependencyPath`. With the function now fully inlined and dev-only, `assertDefined` is also eliminated from production builds, further reducing bundle size. PR Close angular#63354
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production builds,
ngDevModeis replaced withfalse, so the guard compiles toreturn;. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output.Technically, the body is unreachable. But to prove that, the bundler must be 100% certain that:
returncannot be removed by some transformAs thus, it's always conservative.
This also allows dropping
assertDefined, which was previouslyreferenced only inside
prependTokenToDependencyPath. With thefunction now fully inlined and dev-only,
assertDefinedis alsoeliminated from production builds, further reducing bundle size.