Skip to content

Commit b4acc79

Browse files
arturovtthePunderWoman
arturovt
authored and
thePunderWoman
committed
refactor(core): swap dev/prod error handling order in injector for tree-shaking (#63354)
In production builds, `ngDevMode` is replaced with `false`, so the guard compiles to `return;`. However, bundlers like ESBuild still keep the remaining statements after the return as unreachable code instead of removing them. This leaves behind unnecessary dead code in the output. Technically, the body is unreachable. But to prove that, the bundler must be 100% certain that: - `return` cannot be removed by some transform - there's no later transformation that changes control flow As thus, it's always conservative. This also allows dropping `assertDefined`, which was previously referenced only inside `prependTokenToDependencyPath`. With the function now fully inlined and dev-only, `assertDefined` is also eliminated from production builds, further reducing bundle size. PR Close #63354
1 parent e43d9b9 commit b4acc79

File tree

8 files changed

+15
-46
lines changed

8 files changed

+15
-46
lines changed

‎packages/core/src/di/r3_injector.ts‎

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ import {setActiveConsumer} from '@angular/core/primitives/signals';
7979
import {
8080
Injector as PrimitivesInjector,
8181
InjectionToken as PrimitivesInjectionToken,
82-
NOT_FOUND,
8382
NotFound,
8483
isNotFound,
8584
} from '@angular/core/primitives/di';
@@ -392,18 +391,23 @@ export class R3Injector extends EnvironmentInjector implements PrimitivesInjecto
392391
errorCode === RuntimeErrorCode.CYCLIC_DI_DEPENDENCY ||
393392
errorCode === RuntimeErrorCode.PROVIDER_NOT_FOUND
394393
) {
395-
if (!ngDevMode) {
396-
throw new RuntimeError(errorCode, null);
397-
}
398-
399-
prependTokenToDependencyPath(error, token);
394+
// Note: we use `if (ngDevMode) { ... }` instead of an early return.
395+
// ESBuild is conservative about removing dead code that follows `return;`
396+
// inside a function body, so the block may remain in the bundle.
397+
// Using a conditional ensures the dev-only logic is reliably tree-shaken
398+
// in production builds.
399+
if (ngDevMode) {
400+
prependTokenToDependencyPath(error, token);
400401

401-
if (previousInjector) {
402-
// We still have a parent injector, keep throwing
403-
throw error;
402+
if (previousInjector) {
403+
// We still have a parent injector, keep throwing
404+
throw error;
405+
} else {
406+
// Format & throw the final error message when we don't have any previous injector
407+
throw augmentRuntimeError(error, this.source);
408+
}
404409
} else {
405-
// Format & throw the final error message when we don't have any previous injector
406-
throw augmentRuntimeError(error, this.source);
410+
throw new RuntimeError(errorCode, null);
407411
}
408412
} else {
409413
throw error;

‎packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -415,10 +415,8 @@
415415
"applyView",
416416
"areAnimationSupported",
417417
"arrRemove",
418-
"assertDefined",
419418
"assertNotDestroyed",
420419
"attachPatchData",
421-
"augmentRuntimeError",
422420
"balancePreviousStylesIntoKeyframes",
423421
"balanceProperties",
424422
"baseElement",
@@ -551,7 +549,6 @@
551549
"flattenStyles",
552550
"forEachSingleProvider",
553551
"forkInnerZoneWithAngularBehavior",
554-
"formatErrorMessage",
555552
"formatRuntimeError",
556553
"formatRuntimeErrorCode",
557554
"forwardRef",
@@ -808,7 +805,6 @@
808805
"parseTriggerCallbackName",
809806
"performanceMarkFeature",
810807
"pipeFromArray",
811-
"prependTokenToDependencyPath",
812808
"processCleanups",
813809
"processHostBindingOpCodes",
814810
"processInjectorTypesWithProviders",
@@ -909,7 +905,6 @@
909905
"stringifyForError",
910906
"style",
911907
"syncViewWithBlueprint",
912-
"throwError",
913908
"throwInvalidWriteToSignalErrorFn",
914909
"throwProviderNotFoundError",
915910
"timeoutProvider",

‎packages/core/test/bundling/defer/bundle.golden_symbols.json‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -360,10 +360,8 @@
360360
"applyView",
361361
"areAnimationSupported",
362362
"arrRemove",
363-
"assertDefined",
364363
"assertNotDestroyed",
365364
"attachPatchData",
366-
"augmentRuntimeError",
367365
"bind",
368366
"bindingUpdated",
369367
"bloomAdd",
@@ -471,7 +469,6 @@
471469
"findMatchingDehydratedViewForDeferBlock",
472470
"forEachSingleProvider",
473471
"forkInnerZoneWithAngularBehavior",
474-
"formatErrorMessage",
475472
"formatRuntimeError",
476473
"formatRuntimeErrorCode",
477474
"forwardRef",
@@ -685,7 +682,6 @@
685682
"performanceMarkFeature",
686683
"pipeFromArray",
687684
"populateDehydratedViewsInLContainer",
688-
"prependTokenToDependencyPath",
689685
"processCleanups",
690686
"processHostBindingOpCodes",
691687
"processInjectorTypesWithProviders",
@@ -778,7 +774,6 @@
778774
"stringifyForError",
779775
"syncViewWithBlueprint",
780776
"templateCreate",
781-
"throwError",
782777
"throwInvalidWriteToSignalErrorFn",
783778
"throwProviderNotFoundError",
784779
"timeoutProvider",

‎packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -453,11 +453,9 @@
453453
"arrayInsert2",
454454
"assertAllValuesPresent",
455455
"assertControlPresent",
456-
"assertDefined",
457456
"assertNotDestroyed",
458457
"assertPlatform",
459458
"attachPatchData",
460-
"augmentRuntimeError",
461459
"baseElement",
462460
"bind",
463461
"bindingUpdated",
@@ -613,7 +611,6 @@
613611
"formArrayNameProvider",
614612
"formDirectiveProvider",
615613
"formGroupNameProvider",
616-
"formatErrorMessage",
617614
"formatRuntimeError",
618615
"formatRuntimeErrorCode",
619616
"forwardRef",
@@ -932,7 +929,6 @@
932929
"populateDehydratedViewsInLContainer",
933930
"postProducerCreatedFn",
934931
"postSignalSetFn",
935-
"prependTokenToDependencyPath",
936932
"process",
937933
"processCleanups",
938934
"processHostBindingOpCodes",
@@ -1075,7 +1071,6 @@
10751071
"syncPendingControls",
10761072
"syncViewWithBlueprint",
10771073
"templateCreate",
1078-
"throwError",
10791074
"throwInvalidWriteToSignalError",
10801075
"throwInvalidWriteToSignalErrorFn",
10811076
"throwProviderNotFoundError",

‎packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -454,11 +454,9 @@
454454
"arrayInsert2",
455455
"assertAllValuesPresent",
456456
"assertControlPresent",
457-
"assertDefined",
458457
"assertNotDestroyed",
459458
"assertPlatform",
460459
"attachPatchData",
461-
"augmentRuntimeError",
462460
"baseElement",
463461
"bind",
464462
"bindingUpdated",
@@ -611,7 +609,6 @@
611609
"forkJoin",
612610
"formControlBinding",
613611
"formDirectiveProvider",
614-
"formatErrorMessage",
615612
"formatRuntimeError",
616613
"formatRuntimeErrorCode",
617614
"forwardRef",
@@ -927,7 +924,6 @@
927924
"populateDehydratedViewsInLContainer",
928925
"postProducerCreatedFn",
929926
"postSignalSetFn",
930-
"prependTokenToDependencyPath",
931927
"process",
932928
"processCleanups",
933929
"processHostBindingOpCodes",
@@ -1071,7 +1067,6 @@
10711067
"syncPendingControls",
10721068
"syncViewWithBlueprint",
10731069
"templateCreate",
1074-
"throwError",
10751070
"throwInvalidWriteToSignalError",
10761071
"throwInvalidWriteToSignalErrorFn",
10771072
"throwProviderNotFoundError",

‎packages/core/test/bundling/hydration/bundle.golden_symbols.json‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -354,10 +354,8 @@
354354
"applyView",
355355
"areAnimationSupported",
356356
"arrRemove",
357-
"assertDefined",
358357
"assertNotDestroyed",
359358
"attachPatchData",
360-
"augmentRuntimeError",
361359
"baseElement",
362360
"bind",
363361
"bloomAdd",
@@ -486,7 +484,6 @@
486484
"findMatchingDehydratedViewImpl",
487485
"forEachSingleProvider",
488486
"forkInnerZoneWithAngularBehavior",
489-
"formatErrorMessage",
490487
"formatRuntimeError",
491488
"formatRuntimeErrorCode",
492489
"forwardRef",
@@ -721,7 +718,6 @@
721718
"pipeFromArray",
722719
"popScheduler",
723720
"populateDehydratedViewsInLContainerImpl",
724-
"prependTokenToDependencyPath",
725721
"process",
726722
"processCleanups",
727723
"processHostBindingOpCodes",
@@ -826,7 +822,6 @@
826822
"stringifyForError",
827823
"subscribeOn",
828824
"syncViewWithBlueprint",
829-
"throwError",
830825
"throwInvalidWriteToSignalErrorFn",
831826
"throwProviderNotFoundError",
832827
"timeoutProvider",

‎packages/core/test/bundling/router/bundle.golden_symbols.json‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -528,10 +528,8 @@
528528
"argsArgArrayOrObject",
529529
"arrRemove",
530530
"arrayEquals",
531-
"assertDefined",
532531
"assertNotDestroyed",
533532
"attachPatchData",
534-
"augmentRuntimeError",
535533
"baseElement",
536534
"bind",
537535
"bindingUpdated",
@@ -728,7 +726,6 @@
728726
"flattenRouteTree",
729727
"forEachSingleProvider",
730728
"forkInnerZoneWithAngularBehavior",
731-
"formatErrorMessage",
732729
"formatRuntimeError",
733730
"formatRuntimeErrorCode",
734731
"forwardRef",
@@ -1062,7 +1059,6 @@
10621059
"postProducerCreatedFn",
10631060
"postSignalSetFn",
10641061
"prefixedWith",
1065-
"prependTokenToDependencyPath",
10661062
"prioritizedGuardValue",
10671063
"process",
10681064
"processCleanups",
@@ -1226,7 +1222,6 @@
12261222
"tap",
12271223
"textBindingInternal",
12281224
"throwError",
1229-
"throwError2",
12301225
"throwIfEmpty",
12311226
"throwInvalidWriteToSignalError",
12321227
"throwInvalidWriteToSignalErrorFn",

‎packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -294,10 +294,8 @@
294294
"applyView",
295295
"areAnimationSupported",
296296
"arrRemove",
297-
"assertDefined",
298297
"assertNotDestroyed",
299298
"attachPatchData",
300-
"augmentRuntimeError",
301299
"baseElement",
302300
"bind",
303301
"bloomAdd",
@@ -397,7 +395,6 @@
397395
"finalizeConsumerAfterComputation",
398396
"forEachSingleProvider",
399397
"forkInnerZoneWithAngularBehavior",
400-
"formatErrorMessage",
401398
"formatRuntimeError",
402399
"formatRuntimeErrorCode",
403400
"forwardRef",
@@ -579,7 +576,6 @@
579576
"parseCookieValue",
580577
"performanceMarkFeature",
581578
"pipeFromArray",
582-
"prependTokenToDependencyPath",
583579
"processCleanups",
584580
"processHostBindingOpCodes",
585581
"processInjectorTypesWithProviders",
@@ -663,7 +659,6 @@
663659
"stringifyCSSSelectorList",
664660
"stringifyForError",
665661
"syncViewWithBlueprint",
666-
"throwError",
667662
"throwInvalidWriteToSignalErrorFn",
668663
"throwProviderNotFoundError",
669664
"timeoutProvider",

0 commit comments

Comments
 (0)