Skip to content

fix(router): attempt to resolve component resources in JIT mode#63062

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:router-lazy-load-resources
Closed

fix(router): attempt to resolve component resources in JIT mode#63062
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:router-lazy-load-resources

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 8, 2025

In #62758 we started loading the component resources during bootstrap in JIT mode to ensure that they're in place by the time we create the component. This won't work for lazy-loaded components in the router, because they don't exist at bootstrap time.

These changes add similar logic when the router loads a component.

@crisbeto crisbeto requested a review from devversion August 8, 2025 08:34
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 8, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 8, 2025
@crisbeto crisbeto force-pushed the router-lazy-load-resources branch from faab95a to f454ddf Compare August 8, 2025 08:45
@crisbeto
Copy link
Member Author

crisbeto commented Aug 8, 2025

Passing TGP

@crisbeto crisbeto marked this pull request as ready for review August 8, 2025 12:05
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 8, 2025
In angular#62758 we started loading the component resources during bootstrap in JIT mode to ensure that they're in place by the time we create the component. This won't work for lazy-loaded components in the router, because they don't exist at bootstrap time.

These changes add similar logic when the router loads a component.
@crisbeto crisbeto force-pushed the router-lazy-load-resources branch from f454ddf to 2d667d6 Compare August 8, 2025 16:18
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker labels Aug 8, 2025
@atscott
Copy link
Contributor

atscott commented Aug 8, 2025

This PR was merged into the repository by commit 660444f.

The changes were merged into the following branches: main, 20.1.x

@atscott atscott closed this in 660444f Aug 8, 2025
atscott pushed a commit that referenced this pull request Aug 8, 2025
In #62758 we started loading the component resources during bootstrap in JIT mode to ensure that they're in place by the time we create the component. This won't work for lazy-loaded components in the router, because they don't exist at bootstrap time.

These changes add similar logic when the router loads a component.

PR Close #63062
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants