fix(platform-browser): resolve component resources before bootstrapping in JIT mode#62758
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(platform-browser): resolve component resources before bootstrapping in JIT mode#62758crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
…ng in JIT mode Currently if the app has some external resources and it gets bootstrapped in JIT mode, the user will get an error about calling `resolveComponentResources`. These changes add a call to `resolveComponentResources` automatically inside `bootstrapApplication`. Note that we don't need similar logic for `bootstrapModule`, because it calls into `compileNgModuleFactory` internally which in turn calls `resolveComponentResources`.
a7927b8 to
52e1bfa
Compare
devversion
approved these changes
Jul 23, 2025
Member
Author
Contributor
|
This PR was merged into the repository by commit 74d99ed. The changes were merged into the following branches: main, 20.1.x |
kirjs
pushed a commit
that referenced
this pull request
Jul 23, 2025
…ng in JIT mode (#62758) Currently if the app has some external resources and it gets bootstrapped in JIT mode, the user will get an error about calling `resolveComponentResources`. These changes add a call to `resolveComponentResources` automatically inside `bootstrapApplication`. Note that we don't need similar logic for `bootstrapModule`, because it calls into `compileNgModuleFactory` internally which in turn calls `resolveComponentResources`. PR Close #62758
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Aug 8, 2025
In angular#62758 we started loading the component resources during bootstrap in JIT mode to ensure that they're in place by the time we create the component. This won't work for lazy-loaded components in the router, because they don't exist at bootstrap time. These changes add similar logic when the router loads a component.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Aug 8, 2025
In angular#62758 we started loading the component resources during bootstrap in JIT mode to ensure that they're in place by the time we create the component. This won't work for lazy-loaded components in the router, because they don't exist at bootstrap time. These changes add similar logic when the router loads a component.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Aug 8, 2025
In angular#62758 we started loading the component resources during bootstrap in JIT mode to ensure that they're in place by the time we create the component. This won't work for lazy-loaded components in the router, because they don't exist at bootstrap time. These changes add similar logic when the router loads a component.
atscott
pushed a commit
that referenced
this pull request
Aug 8, 2025
In #62758 we started loading the component resources during bootstrap in JIT mode to ensure that they're in place by the time we create the component. This won't work for lazy-loaded components in the router, because they don't exist at bootstrap time. These changes add similar logic when the router loads a component. PR Close #63062
atscott
pushed a commit
that referenced
this pull request
Aug 8, 2025
In #62758 we started loading the component resources during bootstrap in JIT mode to ensure that they're in place by the time we create the component. This won't work for lazy-loaded components in the router, because they don't exist at bootstrap time. These changes add similar logic when the router loads a component. PR Close #63062
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the app has some external resources and it gets bootstrapped in JIT mode, the user will get an error about calling
resolveComponentResources. These changes add a call toresolveComponentResourcesautomatically insidebootstrapApplication.Note that we don't need similar logic for
bootstrapModule, because it calls intocompileNgModuleFactoryinternally which in turn callsresolveComponentResources.