fix(http): Reset headers, progress, and statusCode when using set() in HttpResource#62873
Closed
wartab wants to merge 1 commit intoangular:mainfrom
Closed
fix(http): Reset headers, progress, and statusCode when using set() in HttpResource#62873wartab wants to merge 1 commit intoangular:mainfrom
set() in HttpResource#62873wartab wants to merge 1 commit intoangular:mainfrom
Conversation
… in `HttpResource` Currently, those values aren't reset, which means they are out of sync with the new value
alxhub
approved these changes
Jul 30, 2025
Member
alxhub
left a comment
There was a problem hiding this comment.
This LGTM, but needs a TGP just to be on the safe side.
Member
|
I'll take care of the TGP tomorrow. |
Member
Contributor
|
This PR was merged into the repository by commit e5d6fb5. The changes were merged into the following branches: main, 20.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, those values aren't reset, which means they are out of sync with the new value
This change is slightly opinionated, but it does seem appropriate to me.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previous headers, progress, and statusCode are kept.
Issue Number: N/A
What is the new behavior?
They are reset when setting a custom value.
Does this PR introduce a breaking change?
Other information
Ran into this by accident when checking only for
statusCode()without checking for the actualstatus().