fix(http): Reset headers, progress, and statusCode when using set() in HttpResource (#62873)

wartab · thePunderWoman · commit e5d6fb5825d5 · 2025-08-01T08:08:52.000Z
Currently, those values aren't reset, which means they are out of sync with the new value PR Close #62873
diff --git a/packages/common/http/src/resource.ts b/packages/common/http/src/resource.ts
@@ -393,6 +393,14 @@ class HttpResourceImpl<T>
     this.client = injector.get(HttpClient);
   }
 
+  override set(value: T): void {
+    super.set(value);
+
+    this._headers.set(undefined);
+    this._progress.set(undefined);
+    this._statusCode.set(undefined);
+  }
+
   // This is a type only override of the method
   declare hasValue: () => this is HttpResourceRef<Exclude<T, undefined>>;
 }
diff --git a/packages/common/http/test/resource_spec.ts b/packages/common/http/test/resource_spec.ts
@@ -323,4 +323,19 @@ describe('httpResource', () => {
     req = backend.expectOne('/data');
     req.flush([]);
   });
+
+  it('should reset past request data when using set()', async () => {
+    const backend = TestBed.inject(HttpTestingController);
+    const res = httpResource(() => '/data', {injector: TestBed.inject(Injector)});
+    TestBed.tick();
+    const req = backend.expectOne('/data');
+    req.flush([]);
+    await TestBed.inject(ApplicationRef).whenStable();
+
+    res.set([]);
+
+    expect(res.headers()).toBe(undefined);
+    expect(res.progress()).toBe(undefined);
+    expect(res.statusCode()).toBe(undefined);
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -393,6 +393,14 @@ class HttpResourceImpl<T>`
`393`	`393`	`this.client = injector.get(HttpClient);`
`394`	`394`	`}`
`395`	`395`
	`396`	`+ override set(value: T): void {`
	`397`	`+ super.set(value);`
	`398`	`+`
	`399`	`+ this._headers.set(undefined);`
	`400`	`+ this._progress.set(undefined);`
	`401`	`+ this._statusCode.set(undefined);`
	`402`	`+ }`
	`403`	`+`
`396`	`404`	`// This is a type only override of the method`
`397`	`405`	`declare hasValue: () => this is HttpResourceRef<Exclude<T, undefined>>;`
`398`	`406`	`}`