fix(core): Testing should not throw when Zone does not patch test FW …#61628
Closed
atscott wants to merge 1 commit intoangular:20.0.xfrom
Closed
fix(core): Testing should not throw when Zone does not patch test FW …#61628atscott wants to merge 1 commit intoangular:20.0.xfrom
atscott wants to merge 1 commit intoangular:20.0.xfrom
Conversation
…APIs This prevents `core/testing` from throwing an error if ZoneJS is present but does not patch the test FW APIs such that `fakeAsync` works automatically. For example, there is currently no patching of the vitest APIs, so if you try to use Vitest with Zone on the page, it will throw.
clydin
approved these changes
May 22, 2025
atscott
added a commit
that referenced
this pull request
May 22, 2025
…APIs (#61628) This prevents `core/testing` from throwing an error if ZoneJS is present but does not patch the test FW APIs such that `fakeAsync` works automatically. For example, there is currently no patching of the vitest APIs, so if you try to use Vitest with Zone on the page, it will throw. PR Close #61628
Contributor
Author
|
This PR was merged into the repository by commit 3d4ddd2. The changes were merged into the following branches: 20.0.x |
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
May 23, 2025
…test FW APIs (angular#61628)" This reverts commit 3d4ddd2.
Contributor
|
@atscott This unfortunately broke CI for |
thePunderWoman
added a commit
that referenced
this pull request
May 23, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…APIs
This prevents
core/testingfrom throwing an error if ZoneJS is present but does not patch the test FW APIs such thatfakeAsyncworks automatically. For example, there is currently no patching of the vitest APIs, so if you try to use Vitest with Zone on the page, it will throw.