fix(core): Testing should not throw when Zone does not patch test FW APIs (#61628)

atscott · atscott · commit 3d4ddd224766 · 2025-05-22T12:56:57.000-07:00
This prevents `core/testing` from throwing an error if ZoneJS is present but does not patch the test FW APIs such that `fakeAsync` works automatically. For example, there is currently no patching of the vitest APIs, so if you try to use Vitest with Zone on the page, it will throw. PR Close #61628
diff --git a/packages/core/testing/src/fake_async.ts b/packages/core/testing/src/fake_async.ts
@@ -59,7 +59,7 @@ export function resetFakeAsyncZoneIfExists(): void {
  * @publicApi
  */
 export function fakeAsync(fn: Function, options?: {flush?: boolean}): (...args: any[]) => any {
-  if (fakeAsyncTestModule) {
+  if (fakeAsyncTestModule && (Zone as any)['ProxyZoneSpec']?.isLoaded()) {
     return fakeAsyncTestModule.fakeAsync(fn, options);
   }
   throw new Error(fakeAsyncTestModuleNotLoadedErrorMessage);

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export function resetFakeAsyncZoneIfExists(): void {`
`59`	`59`	`* @publicApi`
`60`	`60`	`*/`
`61`	`61`	`export function fakeAsync(fn: Function, options?: {flush?: boolean}): (...args: any[]) => any {`
`62`		`- if (fakeAsyncTestModule) {`
	`62`	`+ if (fakeAsyncTestModule && (Zone as any)['ProxyZoneSpec']?.isLoaded()) {`
`63`	`63`	`return fakeAsyncTestModule.fakeAsync(fn, options);`
`64`	`64`	`}`
`65`	`65`	`throw new Error(fakeAsyncTestModuleNotLoadedErrorMessage);`