Skip to content

[19.2.x]: Remove legacy circular deps tests and migrate symbol extractor to ts_project#61209

Closed
devversion wants to merge 2 commits intoangular:19.2.xfrom
devversion:rjs-1-patch-2
Closed

[19.2.x]: Remove legacy circular deps tests and migrate symbol extractor to ts_project#61209
devversion wants to merge 2 commits intoangular:19.2.xfrom
devversion:rjs-1-patch-2

Conversation

@devversion
Copy link
Copy Markdown
Member

Patch port of #61156

devversion added 2 commits May 8, 2025 13:28
We don't need this tooling anymore because we are already validating
that there are no circular dependencies via the `ng-dev` tooling that
checks `.ts` files directly.

Also these tests never actually failed to my knowledge.
Migrates the symbol-extractor code to `ts_project`.
@devversion devversion requested a review from josephperrott May 8, 2025 13:29
@devversion devversion added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels May 8, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 8, 2025
@ngbot ngbot bot added this to the Backlog milestone May 8, 2025
@josephperrott josephperrott changed the title [20.0.x]: Remove legacy circular deps tests and migrate symbol extractor to ts_project [19.0.x]: Remove legacy circular deps tests and migrate symbol extractor to ts_project May 8, 2025
@josephperrott josephperrott changed the title [19.0.x]: Remove legacy circular deps tests and migrate symbol extractor to ts_project [19.2.x]: Remove legacy circular deps tests and migrate symbol extractor to ts_project May 8, 2025
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 8, 2025
@devversion devversion marked this pull request as ready for review May 8, 2025 14:54
@alxhub
Copy link
Copy Markdown
Member

alxhub commented May 8, 2025

This PR was merged into the repository by commit d37f508.

The changes were merged into the following branches: 19.2.x

alxhub pushed a commit that referenced this pull request May 8, 2025
We don't need this tooling anymore because we are already validating
that there are no circular dependencies via the `ng-dev` tooling that
checks `.ts` files directly.

Also these tests never actually failed to my knowledge.

PR Close #61209
alxhub pushed a commit that referenced this pull request May 8, 2025
Migrates the symbol-extractor code to `ts_project`.

PR Close #61209
@alxhub alxhub closed this May 8, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants