Skip to content

Remove legacy circular deps tests and migrate symbol extractor to ts_project#61156

Closed
devversion wants to merge 2 commits intoangular:mainfrom
devversion:migrate-symbol-extractor
Closed

Remove legacy circular deps tests and migrate symbol extractor to ts_project#61156
devversion wants to merge 2 commits intoangular:mainfrom
devversion:migrate-symbol-extractor

Conversation

@devversion
Copy link
Copy Markdown
Member

See individual commits

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 7, 2025
@ngbot ngbot bot added this to the Backlog milestone May 7, 2025
@devversion devversion force-pushed the migrate-symbol-extractor branch 2 times, most recently from 5c38739 to a64198d Compare May 7, 2025 11:30
@devversion devversion requested a review from josephperrott May 7, 2025 11:48
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 7, 2025
@devversion devversion marked this pull request as ready for review May 7, 2025 11:48
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devversion added 2 commits May 7, 2025 17:36
We don't need this tooling anymore because we are already validating
that there are no circular dependencies via the `ng-dev` tooling that
checks `.ts` files directly.

Also these tests never actually failed to my knowledge.
Migrates the symbol-extractor code to `ts_project`.
@devversion devversion force-pushed the migrate-symbol-extractor branch from a64198d to ac7ed1c Compare May 7, 2025 17:47
@devversion devversion added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 7, 2025
@AndrewKushnir AndrewKushnir added target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels May 7, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit a1bf58e.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants