Skip to content

[PATCH] docs: rename @nodoc to @docs-private#61196

Closed
mmalerba wants to merge 1 commit intoangular:19.2.xfrom
mmalerba:19.2.x
Closed

[PATCH] docs: rename @nodoc to @docs-private#61196
mmalerba wants to merge 1 commit intoangular:19.2.xfrom
mmalerba:19.2.x

Conversation

@mmalerba
Copy link
Copy Markdown
Contributor

@mmalerba mmalerba commented May 7, 2025

patch version of #61194

@mmalerba mmalerba added target: patch This PR is targeted for the next patch release area: docs Related to the documentation adev: preview labels May 7, 2025
@ngbot ngbot bot modified the milestone: Backlog May 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 7, 2025

Deployed adev-preview for f4f8454c3d93eaac82d18b49018c05f012e458f2 to: https://ng-dev-previews-fw--pr-angular-angular-61196-adev-prev-rzf68x4b.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@mmalerba
docs: rename @nodoc to @docs-private
1caf9e0 
This aligns with how angular/components marks their hidden APIs.
`@nodoc` has been broken since the switch to adev, this change should
properly hide the APIs again.
@pullapprove pullapprove bot requested a review from kirjs May 8, 2025 06:35
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels May 8, 2025
thePunderWoman
thePunderWoman approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

kirjs
kirjs reviewed May 9, 2025
View reviewed changes
@pullapprove pullapprove bot requested a review from devversion May 9, 2025 13:57
@pullapprove pullapprove bot requested a review from devversion May 12, 2025 10:56
devversion
devversion approved these changes May 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-dev-infra-approvers

@alxhub
Copy link
Copy Markdown
Member

alxhub commented May 14, 2025

This PR was merged into the repository by commit 42f203e.

The changes were merged into the following branches: 19.2.x

alxhub pushed a commit that referenced this pull request May 14, 2025
@mmalerba @alxhub
docs: rename @nodoc to @docs-private (#61196)
42f203e 
This aligns with how angular/components marks their hidden APIs.
`@nodoc` has been broken since the switch to adev, this change should
properly hide the APIs again.

PR Close #61196
@alxhub alxhub closed this May 14, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Jun 14, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@kirjs kirjs kirjs approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@mmalerba @alxhub @thePunderWoman @kirjs @devversion