Skip to content

docs: rename @nodoc to @docs-private#61194

Closed
mmalerba wants to merge 1 commit intoangular:mainfrom
mmalerba:nodoc
Closed

docs: rename @nodoc to @docs-private#61194
mmalerba wants to merge 1 commit intoangular:mainfrom
mmalerba:nodoc

Conversation

@mmalerba
Copy link
Copy Markdown
Contributor

@mmalerba mmalerba commented May 7, 2025 •
edited
Loading

This aligns with how angular/components marks their hidden APIs.
@nodoc has been broken since the switch to adev, this change should
properly hide the APIs again.

@mmalerba mmalerba requested review from atscott and devversion May 7, 2025 18:15
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label May 7, 2025
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 7, 2025
@ngbot ngbot bot added this to the Backlog milestone May 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 7, 2025 •
edited
Loading

Deployed adev-preview for a500767 to: https://ng-dev-previews-fw--pr-angular-angular-61194-adev-prev-a70ix8m6.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@mmalerba
Copy link
Copy Markdown
Contributor Author

mmalerba commented May 7, 2025

ex: HashLocationStrategy no longer shows an ngOnDestroy method.

@mmalerba mmalerba force-pushed the nodoc branch 2 times, most recently from 2045822 to 34aca1a Compare May 7, 2025 18:46
JeanMeche
JeanMeche approved these changes May 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the added consistancy

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed target: patch This PR is targeted for the next patch release labels May 7, 2025
@mmalerba
Copy link
Copy Markdown
Contributor Author

mmalerba commented May 7, 2025

caretaker: presubmit is green

@mmalerba mmalerba mentioned this pull request May 7, 2025
Closed
@mmalerba
docs: rename @nodoc to @docs-private
a500767 
This aligns with how angular/components marks their hidden APIs.
`@nodoc` has been broken since the switch to adev, this change should
properly hide the APIs again.
@pullapprove pullapprove bot requested a review from crisbeto May 7, 2025 21:23
@pullapprove pullapprove bot requested a review from devversion May 8, 2025 06:35
devversion
devversion approved these changes May 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from kirjs May 8, 2025 06:36
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels May 8, 2025
thePunderWoman
thePunderWoman approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@alxhub
Copy link
Copy Markdown
Member

alxhub commented May 9, 2025

This PR was merged into the repository by commit c0e9fc1.

The changes were merged into the following branches: main, 20.0.x

@alxhub alxhub closed this in c0e9fc1 May 9, 2025
alxhub pushed a commit that referenced this pull request May 9, 2025
@mmalerba @alxhub
docs: rename @nodoc to @docs-private (#61194)
4d35670 
This aligns with how angular/components marks their hidden APIs.
`@nodoc` has been broken since the switch to adev, this change should
properly hide the APIs again.

PR Close #61194
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Jun 9, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@mmalerba @alxhub @JeanMeche @thePunderWoman @devversion