Skip to content

build: Run browsers tests without platform-browser-dynamic#61060

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:test/platform-browser
Closed

build: Run browsers tests without platform-browser-dynamic#61060
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:test/platform-browser

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Apr 30, 2025 •
edited
Loading

Use the regular platform-browser providers instead.

Previously at #60937, a NoopAnimationModule was missing after a resetTestEnvironment .

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2025
@JeanMeche JeanMeche force-pushed the test/platform-browser branch 2 times, most recently from 88a9eab to d29ffb2 Compare April 30, 2025 12:58
@JeanMeche JeanMeche marked this pull request as ready for review April 30, 2025 12:58
@pullapprove pullapprove bot requested review from josephperrott and kirjs April 30, 2025 12:58
@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label Apr 30, 2025
@pullapprove pullapprove bot requested a review from josephperrott April 30, 2025 13:06
thePunderWoman
thePunderWoman approved these changes Apr 30, 2025
View reviewed changes
@JeanMeche
build: Run browsers tests without platform-browser-dynamic (angular…
eda192c 
…#60937)

Use the regular `platform-browser` providers instead.
@JeanMeche JeanMeche force-pushed the test/platform-browser branch from d29ffb2 to eda192c Compare April 30, 2025 13:24
@JeanMeche JeanMeche changed the title build: Run browsers tests without platform-browser-dynamic (#60937) build: Run browsers tests without platform-browser-dynamic Apr 30, 2025
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 30, 2025
josephperrott
josephperrott approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 30, 2025
@mmalerba
Copy link
Copy Markdown
Contributor

mmalerba commented Apr 30, 2025

This PR was merged into the repository by commit 8f803aa.

The changes were merged into the following branches: main, 19.2.x

mmalerba pushed a commit that referenced this pull request Apr 30, 2025
@JeanMeche @mmalerba
build: Run browsers tests without platform-browser-dynamic (#60937) (…
a554208 
…#61060)

Use the regular `platform-browser` providers instead.

PR Close #61060
@mmalerba mmalerba closed this in 8f803aa Apr 30, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented May 31, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2025
@JeanMeche JeanMeche deleted the test/platform-browser branch June 2, 2025 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@JeanMeche @mmalerba @thePunderWoman @josephperrott