Skip to content

build: Run browsers tests without platform-browser-dynamic#60937

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:browser-tests/pb-dynamic
Closed

build: Run browsers tests without platform-browser-dynamic#60937
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:browser-tests/pb-dynamic

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

Use the regular platform-browser providers instead.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Apr 20, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 20, 2025
@JeanMeche JeanMeche force-pushed the browser-tests/pb-dynamic branch 2 times, most recently from 24882a9 to c3a8ec7 Compare April 20, 2025 15:31
@JeanMeche JeanMeche requested a review from crisbeto April 20, 2025 15:34
@JeanMeche JeanMeche marked this pull request as ready for review April 20, 2025 15:34
@pullapprove pullapprove bot requested a review from josephperrott April 20, 2025 15:34
@JeanMeche JeanMeche force-pushed the browser-tests/pb-dynamic branch from c3a8ec7 to 07222fc Compare April 20, 2025 15:35
@JeanMeche JeanMeche marked this pull request as draft April 20, 2025 15:58
@JeanMeche JeanMeche force-pushed the browser-tests/pb-dynamic branch from 07222fc to 794f914 Compare April 20, 2025 16:17
@JeanMeche JeanMeche marked this pull request as ready for review April 20, 2025 17:02
@JeanMeche JeanMeche force-pushed the browser-tests/pb-dynamic branch 6 times, most recently from 96bcc5b to f91e286 Compare April 21, 2025 21:14
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the dependency on the compiler here. I believe it's fine.

Use the regular `platform-browser` providers instead.
@JeanMeche JeanMeche force-pushed the browser-tests/pb-dynamic branch from f91e286 to 524eae6 Compare April 21, 2025 21:42
@thePunderWoman thePunderWoman removed the request for review from crisbeto April 22, 2025 09:19
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 23, 2025
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 29, 2025
@mmalerba
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit b896ca8.

The changes were merged into the following branches: main, 19.2.x

@mmalerba mmalerba closed this in b896ca8 Apr 29, 2025
mmalerba pushed a commit that referenced this pull request Apr 29, 2025
Use the regular `platform-browser` providers instead.

PR Close #60937
thePunderWoman added a commit to thePunderWoman/angular that referenced this pull request Apr 30, 2025
crisbeto pushed a commit that referenced this pull request Apr 30, 2025
crisbeto pushed a commit that referenced this pull request Apr 30, 2025
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 30, 2025
…#60937)

Use the regular `platform-browser` providers instead.
mmalerba pushed a commit that referenced this pull request Apr 30, 2025
…#61060)

Use the regular `platform-browser` providers instead.

PR Close #61060
mmalerba pushed a commit that referenced this pull request Apr 30, 2025
…#61060)

Use the regular `platform-browser` providers instead.

PR Close #61060
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants