refactor(core): support an opt-in sync version of toObservable#60640
Closed
alxhub wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): support an opt-in sync version of toObservable#60640alxhub wants to merge 1 commit intoangular:mainfrom
toObservable#60640alxhub wants to merge 1 commit intoangular:mainfrom
Conversation
This commit adds a flag `forceSyncFirstEmit` which opts in to the pending new behavior for `toObservable`, which emits the first value synchronously. This flag is only really meant for use during a short migration period while we update g3, and is not meant for prolonged usage. As a result, it's marked deprecated.
67730b3 to
8d94afc
Compare
kirjs
approved these changes
Apr 1, 2025
Contributor
There was a problem hiding this comment.
nit/optional.
I'd just have two functions cleanUp and cleanUpFrominjector, or something similar it'd have some duplicate code, but would be much nicer to read
| expect(emits()).toBe(1); | ||
| }); | ||
|
|
||
| describe('synchronous emit', () => { |
Contributor
There was a problem hiding this comment.
There's a bunch of logic around clean up, would be nice to have that tested.
mmalerba
approved these changes
Apr 1, 2025
Contributor
mmalerba
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit 57a240b. The changes were merged into the following branches: main |
alxhub
added a commit
to alxhub/angular
that referenced
this pull request
Apr 2, 2025
…le` (angular#60640)" This reverts commit 57a240b. We're no longer attempting to convert `toObservable` to a synchronous API.
atscott
pushed a commit
that referenced
this pull request
Apr 2, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a flag
forceSyncFirstEmitwhich opts in to the pending new behavior fortoObservable, which emits the first value synchronously. This flag is only really meant for use during a short migration period while we update g3, and is not meant for prolonged usage. As a result, it's marked deprecated.