Skip to content

Stabilize toObservable#60449

Closed
alxhub wants to merge 2 commits intoangular:mainfrom
alxhub:stable-toobservable
Closed

Stabilize toObservable#60449
alxhub wants to merge 2 commits intoangular:mainfrom
alxhub:stable-toobservable

Conversation

@alxhub
Copy link
Copy Markdown
Member

@alxhub alxhub commented Mar 18, 2025

No description provided.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Mar 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 18, 2025
@alxhub alxhub added the requires: TGP This PR requires a passing TGP before merging is allowed label Mar 18, 2025
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Mar 18, 2025
@JeanMeche JeanMeche added the requires: TGP This PR requires a passing TGP before merging is allowed label Mar 18, 2025
@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Mar 18, 2025
@alxhub alxhub force-pushed the stable-toobservable branch from 2f3384b to 7f35c8e Compare March 21, 2025 22:06
@alxhub alxhub force-pushed the stable-toobservable branch from 7f35c8e to 8e76c12 Compare March 24, 2025 15:29
@JeanMeche JeanMeche mentioned this pull request Mar 24, 2025
Closed
@alxhub alxhub force-pushed the stable-toobservable branch from 8e76c12 to 366ec63 Compare March 31, 2025 22:34
alxhub added 2 commits April 2, 2025 10:11
@alxhub
Revert "refactor(core): support an opt-in sync version of `toObservab…
a227d7d 
…le` (angular#60640)"

This reverts commit 57a240b. We're no
longer attempting to convert `toObservable` to a synchronous API.
@alxhub
feat(core): mark toObservable as stable
e3c42d1 
`toObservable` graduates from developer preview and is now considered stable
API.
@alxhub alxhub force-pushed the stable-toobservable branch from 366ec63 to e3c42d1 Compare April 2, 2025 17:20
@alxhub alxhub changed the title Adjust timing of toObservable and stabilize the API Stabilize toObservable Apr 2, 2025
alfaproject
alfaproject reviewed Apr 2, 2025
View reviewed changes
packages/core/rxjs-interop/src/to_observable.ts
}

/**
* New version of `toObservable` with always-synchronous first emit.
Copy link
Copy Markdown
Contributor

@alfaproject alfaproject Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we gave up on this version?

Copy link
Copy Markdown
Member

@JeanMeche JeanMeche Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A synchronous toObservable(myRequiredInput) would be very inconvinient.

atscott
atscott approved these changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

AndrewKushnir
AndrewKushnir approved these changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@alxhub alxhub added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 2, 2025
@ngbot
Copy link
Copy Markdown

ngbot bot commented Apr 2, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending 3 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alxhub alxhub added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 2, 2025
@alxhub
Copy link
Copy Markdown
Member Author

alxhub commented Apr 2, 2025

Caretaker: G3 failures are flakes/unrelated - this is good to merge.

@atscott
Copy link
Copy Markdown
Contributor

atscott commented Apr 2, 2025

This PR was merged into the repository by commit 4e88e18.

The changes were merged into the following branches: main

@atscott atscott closed this in 45f909e Apr 2, 2025
atscott pushed a commit that referenced this pull request Apr 2, 2025
@alxhub @atscott
feat(core): mark toObservable as stable (#60449)
4e88e18 
`toObservable` graduates from developer preview and is now considered stable
API.

PR Close #60449
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented May 3, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@atscott atscott atscott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@devversion devversion Awaiting requested review from devversion

@mmalerba mmalerba Awaiting requested review from mmalerba

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

+1 more reviewer

@alfaproject alfaproject alfaproject left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@alxhub @atscott @alfaproject @JeanMeche @AndrewKushnir