refactor(core): use stream in rxResource instead of loader#59910
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): use stream in rxResource instead of loader#59910cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
d54029f to
56895b2
Compare
atscott
approved these changes
Feb 19, 2025
thePunderWoman
approved these changes
Feb 19, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
With the changes in angular#59573, `resource` can now define a `stream` rather than a `loader`. In the same PR, `rxResource` was updated to leverage this new functionality to handle multiple responses from the underlying observable, rather than just the first one as it was previously. This commit renames the `loader` option of `rxResource` into `stream` to be better aligned with its new behavior. The previous version is temporarily kept and marked as deprecated to help migrating the current usage. Before ``` usersResource = rxResource({ request: () => ..., loader: ({ request }) => ... }); ``` After ``` usersResource = rxResource({ request: () => ..., stream: ({ request }) => ... }); ```
56895b2 to
ee18be2
Compare
mmalerba
approved these changes
Feb 19, 2025
mmalerba
approved these changes
Feb 19, 2025
mmalerba
approved these changes
Feb 19, 2025
Contributor
mmalerba
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit 98a584c. The changes were merged into the following branches: main, 19.2.x |
atscott
pushed a commit
that referenced
this pull request
Apr 8, 2025
With the changes in #59573, `resource` can now define a `stream` rather than a `loader`. In the same PR, `rxResource` was updated to leverage this new functionality to handle multiple responses from the underlying observable, rather than just the first one as it was previously. This commit renames the `loader` option of `rxResource` into `stream` to be better aligned with its new behavior. The previous version is temporarily kept and marked as deprecated to help migrating the current usage. Before ``` usersResource = rxResource({ request: () => ..., loader: ({ request }) => ... }); ``` After ``` usersResource = rxResource({ request: () => ..., stream: ({ request }) => ... }); ``` PR Close #59910
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Apr 9, 2025
…ngular#59910)" This reverts commit 98a584c.
Member
|
We had to revert the change since it introduced a breakage inside g3. (the |
atscott
pushed a commit
that referenced
this pull request
Apr 9, 2025
atscott
pushed a commit
that referenced
this pull request
Apr 9, 2025
Member
Author
|
Thanks for the feedback @JeanMeche |
Member
|
Alex picked up that change with others in #60919. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
With the changes in #59573,
resourcecan now define astreamrather than aloader. In the same PR,rxResourcewas updated to leverage this new functionality to handle multiple responses from the underlying observable, rather than just the first one as it was previously.What is the new behavior?
This commit renames the
loaderoption ofrxResourceintostreamto be better aligned with its new behavior.The previous version is temporarily kept and marked as deprecated to help migrating the current usage.
Does this PR introduce a breaking change?
Other information
This was briefly discussed with @alxhub on Slack