Several API updates for resource & friends from the RFC#60919
Closed
alxhub wants to merge 4 commits intoangular:mainfrom
Closed
Several API updates for resource & friends from the RFC#60919alxhub wants to merge 4 commits intoangular:mainfrom
resource & friends from the RFC#60919alxhub wants to merge 4 commits intoangular:mainfrom
Conversation
14 tasks
mmalerba
approved these changes
Apr 21, 2025
Contributor
mmalerba
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
thePunderWoman
approved these changes
Apr 22, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM
reviewed-for: fw-general, angular-dev, public-api
Remove the code related to exposing the response of an HTTP request as a `Resource` itself, as the final API will not go in this direction.
An outcome of the Resource RFC was that we should use string constants for communicating the resource status instead of an enum. This commit converts `ResourceStatus` accordingly.
As decided in the resource RFC, this commit renames the `request` option of a resource to `params`, including the subsequent argument passed to the loader. It also corrects the type in the process to properly allow narrowing of the `undefined` value. Fixes angular#58871
As decided in the Resource RFC, this commit renames `loader` in `rxResource` to `stream`. Some logic is left in to support gradual rollout of this change in g3.
Member
Author
|
Caretaker: this requires a g3 patch and g3 updates from cl/750662376. TESTED=https://fusion2.corp.google.com/presubmit/749674791/OCL:749674791:BASE:750345722:1745407048633:fa4a8747/targets (TGP on TAP train, failures unrelated) |
Contributor
|
This PR was merged into the repository by commit 4bcf183. The changes were merged into the following branches: main |
mmalerba
pushed a commit
that referenced
this pull request
Apr 23, 2025
An outcome of the Resource RFC was that we should use string constants for communicating the resource status instead of an enum. This commit converts `ResourceStatus` accordingly. PR Close #60919
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.