PR 59678 for 19.1.x#59735
Closed
pkozlowski-opensource wants to merge 3 commits intoangular:19.1.xfrom
Closed
Conversation
…angular#59678) Make extractAttrsAndClassesFromSelector to return TAttributes directly to simplify the overall logic and remove unecessary code. PR Close angular#59678
Move more logic to a constructor of a ComponentRef. PR Close angular#59678
LifecycleHooksFeature seems to be unused and can be deleted. PR Close angular#59678
thePunderWoman
approved these changes
Jan 27, 2025
crisbeto
approved these changes
Jan 27, 2025
Member
Author
|
This PR was merged into the repository by commit 068cf29. The changes were merged into the following branches: 19.1.x |
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 27, 2025
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 27, 2025
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 27, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a version of the PR #59678 for the 19.1.x branch