refactor(core): simplify attributes extraction logic for ComponentRef#59678
Closed
pkozlowski-opensource wants to merge 3 commits intoangular:mainfrom
Closed
Conversation
Make extractAttrsAndClassesFromSelector to return TAttributes directly to simplify the overall logic and remove unecessary code.
Move more logic to a constructor of a ComponentRef.
LifecycleHooksFeature seems to be unused and can be deleted.
crisbeto
approved these changes
Jan 23, 2025
Member
Author
|
This PR was merged into the repository by commit df143b4. The changes were merged into the following branches: main |
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 27, 2025
Move more logic to a constructor of a ComponentRef. PR Close #59678
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 27, 2025
LifecycleHooksFeature seems to be unused and can be deleted. PR Close #59678
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Jan 27, 2025
…angular#59678) Make extractAttrsAndClassesFromSelector to return TAttributes directly to simplify the overall logic and remove unecessary code. PR Close angular#59678
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Jan 27, 2025
Move more logic to a constructor of a ComponentRef. PR Close angular#59678
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Jan 27, 2025
LifecycleHooksFeature seems to be unused and can be deleted. PR Close angular#59678
Closed
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 27, 2025
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 27, 2025
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 27, 2025
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…angular#59678) Make extractAttrsAndClassesFromSelector to return TAttributes directly to simplify the overall logic and remove unecessary code. PR Close angular#59678
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Move more logic to a constructor of a ComponentRef. PR Close angular#59678
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
LifecycleHooksFeature seems to be unused and can be deleted. PR Close angular#59678
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make extractAttrsAndClassesFromSelector to return TAttributes directly to simplify the overall logic and remove unnecessary code.