Skip to content

fix(core): ensure type is preserved during HMR#59700

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:hmr-type
Closed

fix(core): ensure type is preserved during HMR#59700
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:hmr-type

Conversation

@crisbeto
Copy link
Copy Markdown
Member

Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op.

Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 24, 2025
@crisbeto crisbeto requested a review from clydin January 24, 2025 11:40
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 24, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 24, 2025
@clydin clydin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 24, 2025
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Jan 24, 2025
@pkozlowski-opensource
Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 8287624.

The changes were merged into the following branches: main, 19.1.x

pkozlowski-opensource pushed a commit that referenced this pull request Jan 24, 2025
Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op.

PR Close #59700
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op.

PR Close angular#59700
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants