fix(core): ensure type is preserved during HMR (#59700)

crisbeto · pkozlowski-opensource · commit 82876242e557 · 2025-01-24T17:16:58.000+01:00
Fixes an internal HMR issue where the type might be replaced when swapping out the definition. Externally this is a no-op. PR Close #59700
diff --git a/packages/core/src/render3/hmr.ts b/packages/core/src/render3/hmr.ts
@@ -116,6 +116,11 @@ function mergeWithExistingDefinition(
     // Preserve the old `setInput` function, because it has some state.
     // This is fine, because the component instance is preserved as well.
     setInput: clone.setInput,
+
+    // Externally this is redundant since we redeclare the definition using the original type.
+    // Internally we may receive a definition with an alternate, but identical, type so we have
+    // to ensure that the original one is preserved.
+    type: clone.type,
   });
 
   ngDevMode && assertEqual(replacement, currentDef, 'Expected definition to be merged in place');
