Skip to content

Revert of "fix(core): Defer afterRender until after first CD"#59455

Closed
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
AndrewKushnir:revert_58250
Closed

Revert of "fix(core): Defer afterRender until after first CD"#59455
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
AndrewKushnir:revert_58250

Conversation

@AndrewKushnir
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir commented Jan 9, 2025 •
edited
Loading

Reason for revert: there are some failing targets internally.

@AndrewKushnir AndrewKushnir marked this pull request as ready for review January 9, 2025 19:07
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: core Issues related to the framework runtime labels Jan 9, 2025
@ngbot
Copy link
Copy Markdown

ngbot bot commented Jan 9, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ngbot ngbot bot added this to the Backlog milestone Jan 9, 2025
@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jan 9, 2025
@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 9, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor Author

AndrewKushnir commented Jan 9, 2025

Caretaker note: the CI is "green", the affected test is "green" with this revert. We'll run a presubmit as a part of the sync CL. This PR is ready for merge.

@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Jan 9, 2025

This PR was merged into the repository by commit ac2dbe3.

The changes were merged into the following branches: main, 19.1.x

@kirjs kirjs closed this in 21f1ba2 Jan 9, 2025
kirjs pushed a commit that referenced this pull request Jan 9, 2025
@AndrewKushnir @kirjs
Revert "fix(core): Defer afterRender until after first CD (#58250)" (#…
ac2dbe3 
…59455)

This reverts commit 9870b64.

PR Close #59455
kirjs pushed a commit that referenced this pull request Jan 9, 2025
@AndrewKushnir @kirjs
Revert "fix(core): Don't run effects in check no changes pass (#58250)…
213d1b3 
…" (#59455)

This reverts commit a5fc962.

PR Close #59455
kirjs pushed a commit that referenced this pull request Jan 9, 2025
@AndrewKushnir @kirjs
Revert "fix(core): Defer afterRender until after first CD (#58250)" (#…
679d4d1 
…59455)

This reverts commit 9870b64.

PR Close #59455
@AndrewKushnir AndrewKushnir mentioned this pull request Jan 9, 2025
Closed
@mmalerba mmalerba mentioned this pull request Jan 16, 2025
Closed
mmalerba added a commit to mmalerba/angular that referenced this pull request Jan 16, 2025
@mmalerba
fix(core): Don't run effects in check no changes pass (angular#59455)
a803957 
This reverts commit 21f1ba2.
mmalerba added a commit to mmalerba/angular that referenced this pull request Jan 16, 2025
@mmalerba
fix(core): Defer afterRender until after first CD (angular#59455)
8b49a65 
This reverts commit ac2dbe3.
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@AndrewKushnir @PrajaktaB27
Revert "fix(core): Don't run effects in check no changes pass (angula…
90f53e6 
…r#58250)" (angular#59455)

This reverts commit a5fc962.

PR Close angular#59455
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@AndrewKushnir @PrajaktaB27
Revert "fix(core): Defer afterRender until after first CD (angular#58250
d464873 
)" (angular#59455)

This reverts commit 9870b64.

PR Close angular#59455
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Feb 9, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@kirjs kirjs kirjs approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewKushnir @kirjs @thePunderWoman