fix(core): Defer afterRender until after first CD#58250
Closed
mmalerba wants to merge 0 commit intoangular:mainfrom
Closed
fix(core): Defer afterRender until after first CD#58250mmalerba wants to merge 0 commit intoangular:mainfrom
mmalerba wants to merge 0 commit intoangular:mainfrom
Conversation
devversion
approved these changes
Oct 18, 2024
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM for dev-infra. cc. @josephperrott
alxhub
approved these changes
Jan 6, 2025
Contributor
|
This PR was merged into the repository by commit a5fc962. The changes were merged into the following branches: main |
Contributor
|
Reopening this PR, since the change was reverted via #59455 due to failing targets in g3 (we'll need a TGP for this change). |
Contributor
|
Saw this in the 19.1 release notes. Looks like the commit didn't close out this issue for some reason. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
afterRender/afterNextRendercalls associated with a particular view, ensure that they are not registered until after the first time the view is rendered.