Skip to content

refactor(core): remove outdated comment.#59401

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:core/isStandalone
Closed

refactor(core): remove outdated comment.#59401
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:core/isStandalone

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Jan 7, 2025

Should have been done by #58238, but was probably missed in a rebase.

fixes #59397

@pullapprove pullapprove bot requested a review from kirjs January 7, 2025 14:23
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 7, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 7, 2025
kirjs
kirjs approved these changes Jan 7, 2025
View reviewed changes
packages/core/src/render3/def_getters.ts Outdated
Copy link
Copy Markdown
Contributor

@kirjs kirjs Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit/optional

this expression seems to be the same as def !== null && def.standalone which is shorted and a bit easier to understand? Feel free to ignore if you don't want to change this, since it's not directly related to the purpose of this PR

Copy link
Copy Markdown
Member Author

@JeanMeche JeanMeche Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your suggestion is better !

Copy link
Copy Markdown
Member Author

@JeanMeche JeanMeche Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And btw that's how esbuild minifies it https://esbuild.github.io/try/#dAAwLjI0LjAALS1taW5pZnkgAGRlZiAhPT0gbnVsbCA/IGRlZi5zdGFuZGFsb25lIDogZmFsc2U7 :)

@JeanMeche
refactor(core): remove outdated comment.
44d2bb9 
Should have been done by angular#58238, but was probably missed in a rebase.

fixes angular#59397
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Jan 7, 2025
@ngbot ngbot bot modified the milestone: Backlog Jan 7, 2025
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 7, 2025
thePunderWoman pushed a commit that referenced this pull request Jan 7, 2025
@JeanMeche @thePunderWoman
refactor(core): remove outdated comment. (#59401)
c82ad87 
Should have been done by #58238, but was probably missed in a rebase.

fixes #59397

PR Close #59401
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Jan 7, 2025

This PR was merged into the repository by commit aaf1fbb.

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Feb 7, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@JeanMeche @PrajaktaB27
refactor(core): remove outdated comment. (angular#59401)
65642e6 
Should have been done by angular#58238, but was probably missed in a rebase.

fixes angular#59397

PR Close angular#59401
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kirjs kirjs kirjs approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

isStandalone still defaulting to false

3 participants

@JeanMeche @thePunderWoman @kirjs