Skip to content

refactor(core): Don't genrate standalone: true for definitions#58238

Closed
JeanMeche wants to merge 3 commits intoangular:mainfrom
JeanMeche:refactor/compiler-standalone-default
Closed

refactor(core): Don't genrate standalone: true for definitions#58238
JeanMeche wants to merge 3 commits intoangular:mainfrom
JeanMeche:refactor/compiler-standalone-default

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Oct 17, 2024 •
edited
Loading

On top of #58236

See individual commits.

@angular-robot angular-robot bot added area: core Issues related to the framework runtime area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 17, 2024
@JeanMeche JeanMeche force-pushed the refactor/compiler-standalone-default branch from 35ffae6 to a995d89 Compare October 17, 2024 13:50
@angular-robot angular-robot bot added area: core Issues related to the framework runtime area: compiler Issues related to `ngc`, Angular's template compiler area: language-service Issues related to Angular's VS Code language service and removed area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Oct 17, 2024
@ngbot ngbot bot modified the milestone: Backlog Oct 17, 2024
@JeanMeche JeanMeche force-pushed the refactor/compiler-standalone-default branch from a995d89 to 17ab637 Compare October 17, 2024 13:57
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Oct 17, 2024
@JeanMeche JeanMeche force-pushed the refactor/compiler-standalone-default branch from 17ab637 to 8fbf0a1 Compare October 17, 2024 14:12
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 17, 2024
@JeanMeche JeanMeche force-pushed the refactor/compiler-standalone-default branch from 8fbf0a1 to 053ef27 Compare October 17, 2024 14:29
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 17, 2024
@JeanMeche JeanMeche force-pushed the refactor/compiler-standalone-default branch from 51b2040 to 6f06886 Compare October 17, 2024 15:11
@angular-robot angular-robot bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 17, 2024
@JeanMeche JeanMeche marked this pull request as ready for review October 17, 2024 15:27
@pullapprove pullapprove bot requested a review from alxhub October 17, 2024 15:27
@pullapprove pullapprove bot requested a review from AndrewKushnir October 21, 2024 23:01
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: merge The PR is ready for merge by the caretaker labels Oct 21, 2024
@pullapprove pullapprove bot requested a review from alxhub October 21, 2024 23:04
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 21, 2024
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Oct 22, 2024

Caretaker: this is "green" in g3

@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 22, 2024
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Oct 22, 2024

@JeanMeche there are a couple of merge conflicts with the main branch. Could you please rebase this PR and resolve conflicts when you get a chance?

@JeanMeche
refactor(core): Don't generate standalone: true for definitions
dcfa334 
The runtime default is now `standalone: true`.
`ɵɵdefineComponent`, `ɵɵdefineDirective` and `ɵɵdefinePipe` now set `standalone` as `true` by default in the definitions.
@JeanMeche
refactor(compiler): update compliance tests.
1a55879 
`standalone: true` is now the default at runtime.
@JeanMeche
refactor(language-service): support standalone by default
1b8d86b 
`isStandaloneDecorator()` returns `false` only when the component is explicitly not standalone
@JeanMeche JeanMeche force-pushed the refactor/compiler-standalone-default branch from d748fdd to 1b8d86b Compare October 22, 2024 20:28
@JeanMeche JeanMeche removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 22, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime area: compiler Issues related to `ngc`, Angular's template compiler and removed area: docs Related to the documentation area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Oct 22, 2024
@JeanMeche JeanMeche mentioned this pull request Oct 23, 2024
Closed
@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels Oct 24, 2024
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Oct 24, 2024

This PR was merged into the repository by commit 8af71c0.

The changes were merged into the following branches: main, 19.0.x

alxhub pushed a commit that referenced this pull request Oct 24, 2024
@JeanMeche @alxhub
refactor(core): Don't generate standalone: true for definitions (#5…
61a732d 
…8238)

The runtime default is now `standalone: true`.
`ɵɵdefineComponent`, `ɵɵdefineDirective` and `ɵɵdefinePipe` now set `standalone` as `true` by default in the definitions.

PR Close #58238
alxhub pushed a commit that referenced this pull request Oct 24, 2024
@JeanMeche @alxhub
refactor(compiler): update compliance tests. (#58238)
d9ac59c 
`standalone: true` is now the default at runtime.

PR Close #58238
alxhub pushed a commit that referenced this pull request Oct 24, 2024
@JeanMeche @alxhub
refactor(language-service): support standalone by default (#58238)
aadcfda 
`isStandaloneDecorator()` returns `false` only when the component is explicitly not standalone

PR Close #58238
@alxhub alxhub closed this in a10f7cf Oct 24, 2024
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Nov 24, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

@alxhub alxhub Awaiting requested review from alxhub

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime area: docs-infra Angular.dev application and infrastructure area: language-service Issues related to Angular's VS Code language service merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

v19 Feature Freeze Candidates

Development

Successfully merging this pull request may close these issues.

4 participants

@JeanMeche @alxhub @AndrewKushnir @devversion