Skip to content

refactor(core): standalone by default for JIT compiled directives#58236

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/standalone-jit
Closed

refactor(core): standalone by default for JIT compiled directives#58236
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/standalone-jit

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Oct 16, 2024

This commit fixes the standalone by default for JIT compiled directives (like in unit tests)

@pullapprove pullapprove bot requested a review from thePunderWoman October 16, 2024 23:30
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Oct 16, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 16, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 16, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 16, 2024
@JeanMeche
refactor(core): standalone by default for JIT compiled directives
b9a1933 
This commit fixes the standalone by default for JIT compiled directives (like in unit tests)
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 16, 2024
@JeanMeche JeanMeche mentioned this pull request Oct 16, 2024
Closed
@JeanMeche JeanMeche removed the request for review from thePunderWoman October 17, 2024 02:05
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Oct 17, 2024
This was referenced Oct 17, 2024
Closed
Closed
@devversion
Copy link
Copy Markdown
Member

devversion commented Oct 17, 2024

Do you know why we didn't see any tests failing for this?

@JoostK JoostK mentioned this pull request Oct 17, 2024
Closed
@devversion devversion added the action: presubmit The PR is in need of a google3 presubmit label Oct 17, 2024
@devversion
Copy link
Copy Markdown
Member

devversion commented Oct 17, 2024

This PR was merged into the repository by commit 141f310.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Nov 17, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: core Issues related to the framework runtime target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanMeche @devversion @alxhub