Skip to content

fix(core): cancel in-progress request when same value is assigned#59280

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:59272/resource-same-value
Closed

fix(core): cancel in-progress request when same value is assigned#59280
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:59272/resource-same-value

Conversation

@crisbeto
Copy link
Copy Markdown
Member

Fixes that resource wasn't cancelling its in-progress request if the same value as the current one is assigned.

Fixes #59272.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 22, 2024
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Dec 22, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 22, 2024
@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 22, 2024
@crisbeto crisbeto marked this pull request as ready for review December 22, 2024 08:22
@crisbeto crisbeto requested a review from alxhub December 22, 2024 08:22
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Jan 28, 2025

Hey @crisbeto, can you rebase this before I take a look? I want to make sure I'm reviewing after the most recent resource changes.

@crisbeto crisbeto force-pushed the 59272/resource-same-value branch 3 times, most recently from 2fd2f3e to ebccd26 Compare January 28, 2025 20:47
Fixes that `resource` wasn't cancelling its in-progress request if the same value as the current one is assigned.

Fixes angular#59272.
@crisbeto crisbeto force-pushed the 59272/resource-same-value branch from ebccd26 to 1f07f71 Compare January 28, 2025 20:54
@crisbeto crisbeto removed the request for review from pkozlowski-opensource January 28, 2025 20:56
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 28, 2025
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Jan 29, 2025

This PR was merged into the repository by commit 96e602e.

The changes were merged into the following branches: main

@alxhub alxhub closed this in 96e602e Jan 29, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
…gular#59280)

Fixes that `resource` wasn't cancelling its in-progress request if the same value as the current one is assigned.

Fixes angular#59272.

PR Close angular#59280
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling resource.set(value) does not abort in-progress loaders if the given value is equal to the value before the resource was reloaded

2 participants