fix(core): cancel in-progress request when same value is assigned (#59280)

crisbeto · alxhub · commit 96e602ebe9cd · 2025-01-29T08:40:11.000-08:00
Fixes that `resource` wasn't cancelling its in-progress request if the same value as the current one is assigned. Fixes #59272. PR Close #59280
diff --git a/packages/core/src/resource/resource.ts b/packages/core/src/resource/resource.ts
@@ -221,7 +221,11 @@ class ResourceImpl<T, R> extends BaseWritableResource<T> implements ResourceRef<
     }
 
     const current = untracked(this.value);
-    if (this.equal ? this.equal(current, value) : current === value) {
+
+    if (
+      untracked(this.status) === ResourceStatus.Local &&
+      (this.equal ? this.equal(current, value) : current === value)
+    ) {
       return;
     }
 
diff --git a/packages/core/test/resource/resource_spec.ts b/packages/core/test/resource/resource_spec.ts
@@ -622,6 +622,59 @@ describe('resource', () => {
     stream.set({error: 'fail'});
     expect(res.value()).toBe(undefined);
   });
+
+  it('should interrupt pending request if the same value is set', async () => {
+    const counter = signal(0);
+    const backend = new MockEchoBackend<{counter: number} | null>();
+    const aborted: ({counter: number} | null)[] = [];
+    const echoResource = resource<{counter: number} | null, {counter: number} | null>({
+      request: () => ({counter: counter()}),
+      loader: ({request, abortSignal}) => {
+        abortSignal.addEventListener('abort', () => backend.abort(request));
+        return backend.fetch(request).catch((reason) => {
+          if (reason === 'aborted') {
+            aborted.push(request);
+          }
+          throw new Error(reason);
+        });
+      },
+      injector: TestBed.inject(Injector),
+    });
+
+    // Start the initial load.
+    TestBed.flushEffects();
+    await Promise.resolve();
+    expect(echoResource.status()).toBe(ResourceStatus.Loading);
+    expect(echoResource.value()).toBe(undefined);
+    expect(echoResource.error()).toBe(undefined);
+    expect(aborted).toEqual([]);
+
+    // Interrupt by setting a value before the request has resolved.
+    echoResource.set(null);
+    TestBed.flushEffects();
+    await backend.flush();
+    expect(echoResource.status()).toBe(ResourceStatus.Local);
+    expect(echoResource.value()).toBe(null);
+    expect(echoResource.error()).toBe(undefined);
+    expect(aborted).toEqual([{counter: 0}]);
+
+    // Reload the resource to trigger another request.
+    echoResource.reload();
+    TestBed.flushEffects();
+    await Promise.resolve();
+    expect(echoResource.status()).toBe(ResourceStatus.Reloading);
+    expect(echoResource.value()).toBe(null);
+    expect(echoResource.error()).toBe(undefined);
+    expect(aborted).toEqual([{counter: 0}]);
+
+    // Interrupt the reload with the same value as before.
+    echoResource.set(null);
+    await backend.flush();
+    expect(echoResource.status()).toBe(ResourceStatus.Local);
+    expect(echoResource.value()).toBe(null);
+    expect(echoResource.error()).toBe(undefined);
+    expect(aborted).toEqual([{counter: 0}, {counter: 0}]);
+  });
 });
 
 function flushMicrotasks(): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,11 @@ class ResourceImpl<T, R> extends BaseWritableResource<T> implements ResourceRef<`
`221`	`221`	`}`
`222`	`222`
`223`	`223`	`const current = untracked(this.value);`
`224`		`- if (this.equal ? this.equal(current, value) : current === value) {`
	`224`	`+`
	`225`	`+ if (`
	`226`	`+ untracked(this.status) === ResourceStatus.Local &&`
	`227`	`+ (this.equal ? this.equal(current, value) : current === value)`
	`228`	`+ ) {`
`225`	`229`	`return;`
`226`	`230`	`}`
`227`	`231`