refactor(core): do not serialize parent block id for top level blocks#59190
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): do not serialize parent block id for top level blocks#59190AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
5 tasks
Contributor
Author
5b8e659 to
e2fa067
Compare
thePunderWoman
approved these changes
Dec 17, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM. Just one suggestion.
e2fa067 to
a3f9c20
Compare
This commit updates incremental hydration-related annotation logic to avoid serializing parent block id when it's `null` (for top-level blocks).
a3f9c20 to
a3f54f5
Compare
Contributor
Author
Contributor
|
This PR was merged into the repository by commit ed05cb5. The changes were merged into the following branches: main, 19.0.x, 19.1.x |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…angular#59190) This commit updates incremental hydration-related annotation logic to avoid serializing parent block id when it's `null` (for top-level blocks). PR Close angular#59190
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates incremental hydration-related annotation logic to avoid serializing parent block id when it's
null(for top-level blocks).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?