refactor(core): add skipped defer blocks count to ngDevMode#59188
refactor(core): add skipped defer blocks count to ngDevMode#59188thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
6d99b22 to
751c340
Compare
751c340 to
50444ad
Compare
There was a problem hiding this comment.
This test seems to reflect the change in the packages/core/src/hydration/annotate.ts file, but I'd like to propose that we add explicit tests (or explicit checks to existing tests) to verify that there are no annotations present for defer blocks without the hydrate triggers.
It looks like we can also omit "t":[] from the serialized data.
There was a problem hiding this comment.
I've also noticed that we serialize "p": null and created a quick PR to avoid this extra annotation (since it's unrelated to trigger data): #59190.
There was a problem hiding this comment.
Yeah that's a good call out.
There was a problem hiding this comment.
This case is the situation where there's an empty t array because of jsaction triggers, which don't get included in the serialized block data. So the defer block is still incrementally hydratable, but there's nothing in the array. Definitely safe to omit from the annotation data.
There was a problem hiding this comment.
OK, explicit tests for these annotations have been added.
50444ad to
d66c173
Compare
This adds the skipped defer blocks to the counts in ngDevMode and the logged hydration information.
d66c173 to
089c9ae
Compare
|
This PR was merged into the repository by commit 4a2df56. The changes were merged into the following branches: main, 19.0.x |
This adds the skipped defer blocks to the counts in ngDevMode and the logged hydration information. PR Close #59188
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…59188) This adds the skipped defer blocks to the counts in ngDevMode and the logged hydration information. PR Close angular#59188
This adds the skipped defer blocks to the counts in ngDevMode and the logged hydration information.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?