Skip to content

docs: fix all brokens links on the API pages#59162

Closed
n0scible wants to merge 6 commits intoangular:mainfrom
n0scible:broken-links-fix
Closed

docs: fix all brokens links on the API pages#59162
n0scible wants to merge 6 commits intoangular:mainfrom
n0scible:broken-links-fix

Conversation

@n0scible
Copy link
Copy Markdown
Contributor

@n0scible n0scible commented Dec 12, 2024 •
edited
Loading

This PR fix is for the broken links on the API
pages mentioned in issue #57591. The fix works
by replacing automatic linking with markdown links
for respective warning packages.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #57591

What is the new behavior?

No more broken link warnings.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

NA

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 16, 2024 •
edited
Loading

Deployed adev-preview for 401155e to: https://ng-dev-previews-fw--pr-angular-angular-59162-adev-prev-noruaxv7.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: docs Related to the documentation labels Dec 16, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 16, 2024
JeanMeche
JeanMeche requested changes Dec 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my comments, we're going in the right directly but we need to adjust the changes.
Thank you.

@JeanMeche JeanMeche force-pushed the broken-links-fix branch 4 times, most recently from db8f729 to fcf2a62 Compare March 4, 2025 18:14
@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Mar 4, 2025
@JeanMeche
Copy link
Copy Markdown
Member

JeanMeche commented Mar 4, 2025

Thanks for your contribution, I've amended some of the links for consistency.

@JeanMeche JeanMeche requested a review from josephperrott March 4, 2025 18:15
thePunderWoman
thePunderWoman approved these changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche self-requested a review March 4, 2025 19:03
JeanMeche
JeanMeche approved these changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 4, 2025
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@n0scible @mmalerba
docs: fix all brokens links on the API pages (#59162)
83abe5f 
This PR fix is for the broken links on the API
pages mentioned in issue #57591.

PR Close #59162
@mmalerba
Copy link
Copy Markdown
Contributor

mmalerba commented Mar 4, 2025

This PR was merged into the repository by commit 286e4da.

The changes were merged into the following branches: main, 19.2.x

mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@JeanMeche @mmalerba
docs(docs-infra): Throw error at build time for invalid links (#59162)
31bbbe9 
PR Close #59162
@mmalerba mmalerba closed this in 6dd8cce Mar 4, 2025
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@JeanMeche @mmalerba
docs(docs-infra): Throw error at build time for invalid links (#59162)
286e4da 
PR Close #59162
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Apr 4, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@n0scible @JeanMeche @mmalerba @thePunderWoman @AndrewKushnir