docs: set syntax highlighting to the remaining Markdown code examples blocks#59088
Closed
hawkgs wants to merge 1 commit intoangular:mainfrom
Closed
docs: set syntax highlighting to the remaining Markdown code examples blocks#59088hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs wants to merge 1 commit intoangular:mainfrom
Conversation
… blocks There are some code blocks that slipped through the initial Regex-es. Related to angular#59026
thePunderWoman
requested changes
Dec 6, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
Looks like all the html cases here are safe to use angular-html instead.
JeanMeche
approved these changes
Dec 7, 2024
thePunderWoman
approved these changes
Jan 14, 2025
Member
|
Caretaker note: The set of approval should be enough, this is a doc only change. |
Contributor
|
This PR was merged into the repository by commit b9155b5. The changes were merged into the following branches: main, 19.0.x, 19.1.x |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
… blocks (angular#59088) There are some code blocks that slipped through the initial Regex-es. Related to angular#59026 PR Close angular#59088
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There are still some code block that are missing syntax highlighting.
What is the new behavior?
There are some code blocks that slipped through the initial regular expressions that I had used due to white space + some broken blocks.
Unfortunately, there is a chance that there are still some blocks without highlighting but I assume they will be a limited number given they'll most likely deviate in some way (e.g. will include an unusual content or a typo).
Related to #59026
Does this PR introduce a breaking change?