docs: set syntax highlighting of code examples MD code blocks#59026
Closed
hawkgs wants to merge 1 commit intoangular:mainfrom
Closed
docs: set syntax highlighting of code examples MD code blocks#59026hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
reviewed
Dec 3, 2024
f0bdac1 to
06a47a4
Compare
|
Deployed adev-preview for a8eb451 to: https://ng-dev-previews-fw--pr-angular-angular-59026-adev-prev-dffbuqen.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
reviewed
Dec 4, 2024
packages/animations/browser/src/dsl/animation_timeline_builder.ts
Outdated
Show resolved
Hide resolved
06a47a4 to
106921f
Compare
Member
Author
|
Leaving a short list with changes after the latest push:
|
Member
|
Looks like angular-ts is not loaded as a valid language and the build fails during the prerender pipeline. |
Member
|
It should be |
Member
Author
|
Yeah, messed up the param at |
106921f to
afeeef1
Compare
Set the syntax highlighting based on the code examples' language.
afeeef1 to
a8eb451
Compare
josephperrott
approved these changes
Dec 4, 2024
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
Member
|
This PR was merged into the repository by commit 0513fbc. The changes were merged into the following branches: main, 19.0.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Dec 4, 2024
Set the syntax highlighting based on the code examples' language. PR Close #59026
hawkgs
added a commit
to hawkgs/angular
that referenced
this pull request
Dec 6, 2024
… blocks There are some code blocks that slipped through the initial Regex-es. Related to angular#59026
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…r#59026) Set the syntax highlighting based on the code examples' language. PR Close angular#59026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, there are quite a few code examples in the API reference that don't have syntax highlighting. Some examples:
What is the new behavior?
By setting the syntax highlighting parameter of the Markdown code blocks, the examples are now displayed properly.
The change most likely also targets code snippets/examples that are not part of the API reference.
Does this PR introduce a breaking change?