Skip to content

Revert "fix(platform-server): remove peer dependency on animations (#…#59051

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:revert/server-animations
Closed

Revert "fix(platform-server): remove peer dependency on animations (#…#59051
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:revert/server-animations

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Dec 4, 2024 •
edited
Loading

…#58997)"

This reverts commit 1cfbfc6.

Fixes #59050

@JeanMeche JeanMeche requested a review from crisbeto December 4, 2024 17:26
@pullapprove pullapprove bot requested a review from alxhub December 4, 2024 17:26
@JeanMeche JeanMeche closed this Dec 4, 2024
@JeanMeche JeanMeche reopened this Dec 4, 2024
@pkozlowski-opensource pkozlowski-opensource added area: server Issues related to server-side rendering target: patch This PR is targeted for the next patch release labels Dec 4, 2024
@ngbot ngbot bot modified the milestone: Backlog Dec 4, 2024
alan-agius4
alan-agius4 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Dec 4, 2024

Caretaker note: presubmit failures are unrelated.

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 4, 2024
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Dec 4, 2024

This PR was merged into the repository by commit 04e074b.

The changes were merged into the following branches: main, 19.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Dec 4, 2024
@JeanMeche @pkozlowski-opensource
Revert "fix(platform-server): remove peer dependency on animations (#…
a7fb45f 
…58997)" (#59051)

This reverts commit 1cfbfc6.

PR Close #59051
@JeanMeche JeanMeche deleted the revert/server-animations branch December 4, 2024 22:04
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Jan 4, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@JeanMeche @PrajaktaB27
Revert "fix(platform-server): remove peer dependency on animations (a…
70476c2 
…ngular#58997)" (angular#59051)

This reverts commit 1cfbfc6.

PR Close angular#59051
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Could not resolve "@angular/animations/browser"

3 participants

@JeanMeche @pkozlowski-opensource @alan-agius4